Skip to content

Commit f977b70

Browse files
authored
Merge pull request #52 from CleverCloud/biscuit-java-v4
biscuit-java 4.0.1
2 parents 786089f + 9dc3e06 commit f977b70

File tree

6 files changed

+113
-91
lines changed

6 files changed

+113
-91
lines changed

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Compiled class file
22
*.class
3-
3+
target/
44
.idea/
55

66
# Log file

pom.xml

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
<maven-compiler-plugin.version>3.10.0</maven-compiler-plugin.version>
2424

2525
<!-- dependencies -->
26-
<biscuit-java.version>3.0.1</biscuit-java.version>
27-
<logback-classic.version>1.2.13</logback-classic.version>
28-
<slf4j-reload4j.version>1.7.36</slf4j-reload4j.version>
26+
<biscuit-java.version>4.0.1</biscuit-java.version>
27+
<logback.version>1.5.17</logback.version>
28+
<slf4j.version>2.0.17</slf4j.version>
2929
<protobuf.version>3.25.5</protobuf.version>
3030
<pulsar.version>3.2.1</pulsar.version>
3131
<vavr.version>0.10.3</vavr.version>
@@ -201,10 +201,21 @@
201201
<version>${pulsar.version}</version>
202202
</dependency>
203203

204+
<dependency>
205+
<groupId>ch.qos.logback</groupId>
206+
<artifactId>logback-core</artifactId>
207+
<version>${logback.version}</version>
208+
</dependency>
204209
<dependency>
205210
<groupId>ch.qos.logback</groupId>
206211
<artifactId>logback-classic</artifactId>
207-
<version>${logback-classic.version}</version>
212+
<version>${logback.version}</version>
213+
</dependency>
214+
<!-- https://mvnrepository.com/artifact/org.slf4j/slf4j-api -->
215+
<dependency>
216+
<groupId>org.slf4j</groupId>
217+
<artifactId>slf4j-api</artifactId>
218+
<version>${slf4j.version}</version>
208219
</dependency>
209220

210221
<dependency>

src/main/resources/logback.xml

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,12 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<configuration>
3-
43
<appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
54
<layout class="ch.qos.logback.classic.PatternLayout">
6-
<pattern>
7-
%d{HH:mm:ss.SSS} [%t] %-5level %logger{36} - %msg%n
8-
</pattern>
5+
<pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n</pattern>
96
</layout>
107
</appender>
118

12-
<logger name="com.clevercloud" level="info" additivity="false">
13-
<appender-ref ref="STDOUT"/>
14-
</logger>
15-
16-
<root level="error">
17-
<appender-ref ref="STDOUT"/>
9+
<root level="INFO">
10+
<appender-ref ref="STDOUT" />
1811
</root>
19-
20-
</configuration>
12+
</configuration>

src/test/java/com/clevercloud/biscuitpulsar/AuthenticationProviderBiscuitTest.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,12 @@ public void testAuthSecretKeyPair() throws Exception {
4242

4343
SymbolTable symbols = Biscuit.default_symbol_table();
4444

45-
Block authority_builder = new Block(0, symbols);
46-
authority_builder.add_fact(fact("right", Arrays.asList(s("topic"), s("public"), s("default"), s("test"), s("produce"))));
45+
Block authorityBuilder = new Block();
46+
authorityBuilder.add_fact(fact("right", Arrays.asList(s("topic"), s("public"), s("default"), s("test"), s("produce"))));
4747

4848
byte[] seed = {0, 0, 0, 0};
4949
SecureRandom rng = new SecureRandom(seed);
50-
Biscuit b = Biscuit.make(rng, root, Biscuit.default_symbol_table(), authority_builder.build());
50+
Biscuit b = Biscuit.make(rng, root, authorityBuilder.build(symbols));
5151

5252
AuthenticationProviderBiscuit provider = new AuthenticationProviderBiscuit();
5353

@@ -126,12 +126,12 @@ public void testTokenFromHttpParams() throws Exception {
126126

127127
SymbolTable symbols = Biscuit.default_symbol_table();
128128

129-
Block authority_builder = new Block(0, symbols);
130-
authority_builder.add_fact(fact("right", Arrays.asList(s("topic"), s("public"), s("default"), s("test"), s("produce"))));
129+
Block authorityBuilder = new Block();
130+
authorityBuilder.add_fact(fact("right", Arrays.asList(s("topic"), s("public"), s("default"), s("test"), s("produce"))));
131131

132132
byte[] seed = {0, 0, 0, 0};
133133
SecureRandom rng = new SecureRandom(seed);
134-
Biscuit b = Biscuit.make(rng, root, Biscuit.default_symbol_table(), authority_builder.build());
134+
Biscuit b = Biscuit.make(rng, root, authorityBuilder.build(symbols));
135135

136136
HttpServletRequest servletRequest = mock(HttpServletRequest.class);
137137
doReturn(b.serialize_b64url()).when(servletRequest).getParameter("token");
@@ -161,12 +161,12 @@ public void testTokenFromHttpHeaders() throws Exception {
161161

162162
SymbolTable symbols = Biscuit.default_symbol_table();
163163

164-
Block authority_builder = new Block(0, symbols);
165-
authority_builder.add_fact(fact("right", Arrays.asList(s("topic"), s("public"), s("default"), s("test"), s("produce"))));
164+
Block authorityBuilder = new Block();
165+
authorityBuilder.add_fact(fact("right", Arrays.asList(s("topic"), s("public"), s("default"), s("test"), s("produce"))));
166166

167167
byte[] seed = {0, 0, 0, 0};
168168
SecureRandom rng = new SecureRandom(seed);
169-
Biscuit b = Biscuit.make(rng, root, Biscuit.default_symbol_table(), authority_builder.build());
169+
Biscuit b = Biscuit.make(rng, root, authorityBuilder.build(symbols));
170170
HttpServletRequest servletRequest = mock(HttpServletRequest.class);
171171
doReturn("Bearer " + b.serialize_b64url()).when(servletRequest).getHeader("Authorization");
172172
doReturn("127.0.0.1").when(servletRequest).getRemoteAddr();
@@ -191,12 +191,12 @@ public void testWrongKeyPair() throws Exception {
191191

192192
SymbolTable symbols = Biscuit.default_symbol_table();
193193

194-
Block authority_builder = new Block(0, symbols);
195-
authority_builder.add_fact(fact("right", Arrays.asList(s("topic"), s("public"), s("default"), s("test"), s("produce"))));
194+
Block authorityBuilder = new Block();
195+
authorityBuilder.add_fact(fact("right", Arrays.asList(s("topic"), s("public"), s("default"), s("test"), s("produce"))));
196196

197197
byte[] seed = {0, 0, 0, 0};
198198
SecureRandom rng = new SecureRandom(seed);
199-
Biscuit b = Biscuit.make(rng, wrongRoot, Biscuit.default_symbol_table(), authority_builder.build());
199+
Biscuit b = Biscuit.make(rng, wrongRoot, authorityBuilder.build(symbols));
200200

201201
AuthenticationProviderBiscuit provider = new AuthenticationProviderBiscuit();
202202

0 commit comments

Comments
 (0)