Skip to content

Commit e36236e

Browse files
ci(typecheck): only enable skipLibCheck in CI
Disabling `skipLibCheck` prevents `tsserver` from type checking all `d.ts` files. Since we author these files manually, it's better to enable type checking for these files within IDEs to avoid human errors. We still disable typechecking in `d.ts` files in CI since we have errors in third party `d.ts` files.
1 parent 7209abe commit e36236e

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@
9090
"test:e2e": "npm run test:e2e:browser && npm run test:e2e:node",
9191
"test:e2e:browser": "web-test-runner --config test-browser-wtr.config.e2e.js",
9292
"test:e2e:node": "mocha --config test-node-mocha.config.e2e.cjs",
93-
"typecheck": "tsc -p tsconfig.json"
93+
"typecheck": "tsc -p tsconfig.ci.json"
9494
},
9595
"dependencies": {
9696
"component-emitter": "^1.3.0",

tsconfig.ci.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"extends": "./tsconfig.json",
3+
"compilerOptions": {
4+
"skipLibCheck": true
5+
}
6+
}

tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"checkJs": true,
1010
"noEmit": true,
1111
"esModuleInterop": true,
12-
"skipLibCheck": true,
12+
"skipLibCheck": false,
1313
"strict": true,
1414
"strictNullChecks": false,
1515
"noUncheckedIndexedAccess": false,

0 commit comments

Comments
 (0)