fix: feedback Bob

Author: Galimede

src/components/cc-plan-item/cc-plan-item.js

@@ -60,7 +60,6 @@ export class CcPlanItem extends LitElement {
   }
 
   /**
-   *
    * @param {PlanDetails} detail
    * @returns TemplateResult
    */

src/components/cc-plan-picker/cc-plan-picker.js

@@ -234,22 +234,18 @@ export class CcPlanPicker extends CcFormControlElement {
         }
 
         .plan-legend-text {
-          --ct-form-label-font-family: 'Source Sans 3';
-          --ct-form-label-font-size: 1.625em;
-          --ct-form-label-font-weight: 500;
-          --ct-form-input-font-size: 1.25em;
-
           color: var(--cc-color-text-primary-strongest);
-          font-family: var(--ct-form-label-font-family), sans-serif;
-          font-size: var(--ct-form-label-font-size);
-          font-weight: var(--ct-form-label-font-weight);
+          font-family: var(--cc-ff-form-legend), inherit;
+          font-size: 1.625em;
+          font-weight: 500;
         }
 
         .form-controls {
           display: grid;
           gap: 1em;
-          grid-template-columns: repeat(auto-fill, minmax(12.5em, 1fr));
-          margin: 1em 2em;
+          grid-template-columns: repeat(auto-fill, minmax(13em, 1fr));
+          margin-block-start: 0.5em;
+          margin-inline-start: 34px;
         }
       `,
     ];

src/components/cc-plan-picker/cc-plan-picker.stories.js

@@ -27,7 +27,7 @@ export const defaultStory = makeStory(conf, {
   /** @type {Array<Partial<CcPlanPicker>>} */
   items: [
     {
-      name: 'foobar',
+      name: 'plan',
       plans: DEFAULT_PLANS,
       value: 'plan_12',
     },
@@ -38,6 +38,7 @@ export const readonly = makeStory(conf, {
   /** @type {Array<Partial<CcPlanPicker>>} */
   items: [
     {
+      name: 'plan',
       plans: DEFAULT_PLANS,
       readonly: true,
       value: 'plan_12',
@@ -49,6 +50,7 @@ export const sampleDatabase = makeStory(conf, {
   /** @type {Array<Partial<CcPlanPicker>>} **/
   items: [
     {
+      name: 'plan',
       plans: [
         {
           name: 'S',
@@ -215,6 +217,7 @@ export const thirdParty = makeStory(conf, {
   /** @type {Array<Partial<CcPlanPicker>>} */
   items: [
     {
+      name: 'plan',
       plans: THIRD_PARTY,
       value: 'third_party_1',
     },
@@ -225,6 +228,7 @@ export const thirdPartyReadonly = makeStory(conf, {
   /** @type {Array<Partial<CcPlanPicker>>} */
   items: [
     {
+      name: 'plan',
       plans: THIRD_PARTY,
       readonly: true,
       value: 'third_party_1',

src/stories/fixtures/plans.js

@@ -220,7 +220,6 @@ export const DEFAULT_PLANS = [
       },
     ],
   },
-
   {
     name: 'L',
     id: 'plan_5',
@@ -363,23 +362,23 @@ export const DEFAULT_PLANS = [
 
 /** @type {PlanItem[]}  **/
 export const THIRD_PARTY = [{
-  id: 'third_party_1',
-  name: 'Third party 1',
-  details: [],
-},
-{
-  id: 'third_party_2',
-  name: 'Third party 2',
-  details: [],
-},
-{
-  id: 'third_party_3',
-  name: 'Third party 3',
-  details: [],
-},
-{
-  id: 'third_party_4',
-  name: 'Third party 4',
-  details: [],
-},
+    id: 'third_party_1',
+    name: 'Third party 1',
+    details: [],
+  },
+  {
+    id: 'third_party_2',
+    name: 'Third party 2',
+    details: [],
+  },
+  {
+    id: 'third_party_3',
+    name: 'Third party 3',
+    details: [],
+  },
+  {
+    id: 'third_party_4',
+    name: 'Third party 4',
+    details: [],
+  },
 ];

src/translations/translations.fr.js

@@ -1066,7 +1066,7 @@ export const translations = {
   //#endregion
   //#region cc-plan-picker
   'cc-plan-picker.legend': `Sélectionnez votre plan`,
-  'cc-plan-picker.legend.customize': `Customisez votre plan`,
+  'cc-plan-picker.legend.customize': `Personnalisez votre plan`,
   //#endregion
   //#region cc-pricing-estimation
   'cc-pricing-estimation.count.label': /** @param {{productCount: number}} _ */ ({ productCount }) =>