remove redundant islinear function, add == tests

Author: odunbar

src/Utilities.jl

@@ -28,6 +28,7 @@ export create_encoder_schedule,
     decode_data,
     decode_structure_matrix,
     norm,
+    isequal_linear,
     encoder_kwargs_from
 
 
@@ -276,14 +277,6 @@ function isequal_linear(
     return true
 end
 
-function isequal_linear(A::AMorV1, B::AMorV2; kwargs...) where {AMorV1 <: AbstractVecOrMat, AMorV2 <: AbstractVecOrMat}
-    if !(size(A) == size(B))
-        return false
-    end
-
-    return all(isequal_linear(a, b; kwargs...) for (a, b) in zip(A[:], B[:]))
-end
-
 function Base.:(==)(a::LM1, b::LM2) where {LM1 <: LinearMap, LM2 <: LinearMap}
     n = size(a, 2)
     if n < 1e4 # gets expensive

test/Utilities/runtests.jl

@@ -104,6 +104,8 @@ end
         A[4].svd_cov.U * Diagonal(A[4].svd_cov.S) * A[4].svd_cov.Vt + A[4].diag_cov
 
 
+    @test_throws ArgumentError create_compact_linear_map(3 * I) # needs dims
+
     for svd_type in ["psvd", "tsvd"]
         psvd_kwargs = (; rtol = 1e-3) # make very small for testing
         tsvd_max_rank = 30 # often only stable small ranks
@@ -116,6 +118,11 @@ end
         )
         Amat_from_map = Matrix(Amap)
 
+        # some extra tests for the ==/is_equal overrides
+        @test Amap == Amap
+        Amap2 = create_compact_linear_map([A[1]])
+        @test !(Amap == Amap2)
+
         for (i, ids) in enumerate(block_id)
             if i == 2 # the case where we do psvd on a full matrix - can be very high error expected (particularly tsvd
                 if svd_type == "psvd"