Restore accidentally-dropped tests from the DataLayouts refactor

- benchmark_stencils.jl: restore the "sphere, VIJFH, Float64" set (main asserted
  both IJFH-F64 and IJHF-F64; the branch kept only the VIJHF-F64 analogue).
- unit_struct.jl: restore the check_basetype testset (was in main's data2d.jl;
  check_basetype is still a live function in DataLayouts.jl). 17/17 pass.
- benchmark_fill.jl (+ cpu/gpu_datalayouts_fill pipeline steps): restore the
  fill! perf benchmark, mirroring benchmark_copyto.jl's coverage (it was deleted
  while benchmark_copyto.jl was kept and broadened).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: dennisYatunin

.buildkite/pipeline.yml

@@ -1578,6 +1578,22 @@ steps:
   - group: "Perf: DataLayouts"
     steps:
 
+      - label: "Perf: DataLayouts fill!"
+        key: "cpu_datalayouts_fill"
+        retry: *retry_policy
+        command: "julia --color=yes --project=.buildkite test/DataLayouts/benchmark_fill.jl"
+
+      - label: "Perf: DataLayouts fill"
+        key: "gpu_datalayouts_fill"
+        retry: *retry_policy
+        command:
+          - "julia --project=.buildkite -e 'using CUDA; CUDA.versioninfo()'"
+          - "julia --color=yes --project=.buildkite test/DataLayouts/benchmark_fill.jl"
+        env:
+          CLIMACOMMS_DEVICE: "CUDA"
+        agents:
+          slurm_gpus: 1
+
       - label: "Perf: DataLayouts copyto!"
         key: "cpu_datalayouts_copyto"
         retry: *retry_policy

test/DataLayouts/benchmark_fill.jl

@@ -0,0 +1,56 @@
+using Test
+using BenchmarkTools
+import ClimaComms
+import ClimaCore: ClimaCore, DataLayouts
+@static pkgversion(ClimaComms) >= v"0.6" && ClimaComms.@import_required_backends
+if ClimaComms.device() isa ClimaComms.CUDADevice
+    import CUDA
+    device_name = CUDA.name(CUDA.device()) # Move to ClimaComms
+else
+    device_name = "CPU"
+end
+
+include(joinpath(pkgdir(ClimaCore), "benchmarks/scripts/benchmark_utils.jl"))
+
+function benchmarkfill!(bm, device, data, val)
+    caller = string(DataLayouts.layout_constructor(data))
+    @info "Benchmarking $caller..."
+    trial = @benchmark ClimaComms.@cuda_sync $device fill!($data, $val)
+    kernel_time_s = minimum(trial.times) * 1e-9 # to seconds
+    nreps = length(trial.times)
+    problem_size = size(data)
+    n_reads_writes = DataLayouts.ncomponents(data)
+    push_info(bm; kernel_time_s, nreps, caller, problem_size, n_reads_writes)
+end
+
+@testset "fill! with Nf = 1" begin
+    device = ClimaComms.device()
+    FT = Float64
+    A = ClimaComms.array_type(device){FT}
+    bm = Benchmark(; float_type = FT, device_name)
+
+    data = DataLayouts.DataF{FT}(A)
+    benchmarkfill!(bm, device, data, 3)
+    @test all(parent(data) .== 3)
+
+    (Nv, Nij, Nh) = (63, 4, 30 * 30 * 6)
+    for Nv in (1, Nv), (Ni, Nj) in ((1, 1), (Nij, 1), (Nij, Nij)), Nh in (1, Nh)
+        for D in (DataLayouts.VIJFH, DataLayouts.VIJHF)
+            data = D{FT, Nv, Ni, Nj, Nh == 1 ? 1 : nothing}(A, Nh)
+            benchmarkfill!(bm, device, data, 3)
+            @test all(parent(data) .== 3)
+        end
+    end
+    for Nv in (1, Nv), Ni in (1, Nij), Nh in (1, Nh)
+        data = DataLayouts.VIH1{FT, Nv, Ni, Nh == 1 ? 1 : nothing}(A, Nh)
+        benchmarkfill!(bm, device, data, 3)
+        @test all(parent(data) .== 3)
+    end
+    for (Ni, Nj) in ((1, 1), (Nij, 1), (Nij, Nij)), Nh in (1, Nh)
+        data = DataLayouts.IH1JH2{FT, Ni, Nj, Nh == 1 ? 1 : nothing}(A, Nh)
+        benchmarkfill!(bm, device, data, 3)
+        @test all(parent(data) .== 3)
+    end
+
+    tabulate_benchmark(bm)
+end

test/DataLayouts/unit_struct.jl

@@ -1,5 +1,5 @@
 using Test
-using ClimaCore.DataLayouts: get_struct, set_struct!, struct_field_view
+using ClimaCore.DataLayouts: get_struct, set_struct!, struct_field_view, check_basetype
 
 struct Foo{T}
     x::T
@@ -70,3 +70,29 @@ end
 end
 
 # TODO: add set_struct!
+
+@testset "check_basetype" begin
+    @test_throws Exception check_basetype(Real, Real)
+    @test_throws Exception check_basetype(Real, Float64)
+    @test_throws Exception check_basetype(Float64, Real)
+
+    @test isnothing(check_basetype(Float64, Float64))
+    @test isnothing(check_basetype(Float32, Float64))
+    @test_throws Exception check_basetype(Float64, Float32)
+
+    @test isnothing(check_basetype(Tuple{}, Tuple{}))
+    @test isnothing(check_basetype(Float64, Tuple{}))
+    @test_throws Exception check_basetype(Tuple{}, Float64)
+
+    S = typeof((a = ((1.0, 2.0f0), (3.0, 4.0f0)), b = (5.0, 6.0f0)))
+    @test isnothing(check_basetype(Float32, S))
+    @test isnothing(check_basetype(Float64, S))
+    @test isnothing(check_basetype(Tuple{Float64, Float32}, S))
+    @test_throws Exception check_basetype(NTuple{4, Float64}, S)
+
+    S = typeof(((), (1.0 + 2.0im, NamedTuple()), 3.0 + 4.0im, ()))
+    @test isnothing(check_basetype(Float32, S))
+    @test isnothing(check_basetype(Float64, S))
+    @test isnothing(check_basetype(Complex{Float64}, S))
+    @test_throws Exception check_basetype(NTuple{5, Float64}, S)
+end

test/Operators/finitedifference/benchmark_stencils.jl

@@ -15,6 +15,12 @@ include("benchmark_stencils_utils.jl")
     (;t_min) = benchmark_operators_column(bm; z_elems = 63, helem = 30, Nq = 4)
     test_results_column(t_min)
 
+    @info "sphere, VIJFH, Float64"
+    bm = Benchmark(;float_type = Float64, device_name)
+    # benchmark_operators_sphere(bm; z_elems = 63, helem = 30, Nq = 4, compile = true)
+    (;t_min) = benchmark_operators_sphere(bm; z_elems = 63, helem = 30, Nq = 4, VIJH = DataLayouts.VIJFH)
+    test_results_sphere(t_min)
+
     @info "sphere, VIJHF, Float64"
     bm = Benchmark(;float_type = Float64, device_name)
     (;t_min) = benchmark_operators_sphere(bm; z_elems = 63, helem = 30, Nq = 4, VIJH = DataLayouts.VIJHF)