Possibly simplify interpolate_atmosphere_state kernel (#424)

* Possibly simplify interp kernel

* Add assert

---------

Co-authored-by: Mosè Giordano <[email protected]>

Author: glwagner

Project.toml

@@ -42,7 +42,7 @@ JLD2 = "0.4, 0.5"
 KernelAbstractions = "0.9"
 MPI = "0.20"
 NCDatasets = "0.12, 0.13, 0.14"
-Oceananigans = "0.95.27 - 0.99"
+Oceananigans = "0.95.28 - 0.99"
 OffsetArrays = "1.14"
 PrecompileTools = "1"
 Scratch = "1"

src/OceanSeaIceModels/InterfaceComputations/interpolate_atmospheric_state.jl

@@ -63,14 +63,17 @@ function interpolate_atmosphere_state!(interfaces, atmosphere::PrescribedAtmosph
 
     # Assumption, should be generalized
     ua = atmosphere.velocities.u
+    times = ua.times
+    time_indexing = ua.time_indexing
+    t = clock.time
+    @assert times isa StepRangeLen
+    time_interpolator = TimeInterpolator(ua.time_indexing, times, clock.time)
 
     launch!(arch, grid, kernel_parameters,
             _interpolate_primary_atmospheric_state!,
             atmosphere_data,
             space_fractional_indices,
-            clock.time,
-            ua.times,
-            ua.time_indexing,
+            time_interpolator,
             exchange_grid,
             atmosphere_velocities,
             atmosphere_tracers,
@@ -120,9 +123,7 @@ end
 
 @kernel function _interpolate_primary_atmospheric_state!(surface_atmos_state,
                                                          space_fractional_indices,
-                                                         time,
-                                                         atmos_times,
-                                                         time_indexing,
+                                                         time_interpolator,
                                                          exchange_grid,
                                                          atmos_velocities,
                                                          atmos_tracers,
@@ -140,7 +141,7 @@ end
     fj = get_fractional_index(i, j, jj)
 
     x_itp = FractionalIndices(fi, fj, nothing)
-    t_itp = TimeInterpolator(time_indexing, atmos_times, time)
+    t_itp = time_interpolator
     atmos_args = (x_itp, t_itp, atmos_backend, atmos_time_indexing)
 
     uₐ = interp_atmos_time_series(atmos_velocities.u, atmos_args...)