Change default gustiness to 1 (#464)

* Update similarity_theory_turbulent_fluxes.jl

* Update PrescribedAtmospheres.jl

* Update PrescribedAtmospheres.jl

* Update similarity_theory_turbulent_fluxes.jl

* Update src/OceanSeaIceModels/InterfaceComputations/similarity_theory_turbulent_fluxes.jl

* Update src/OceanSeaIceModels/PrescribedAtmospheres.jl

* Update src/OceanSeaIceModels/PrescribedAtmospheres.jl

* Apply suggestions from code review

* Update PrescribedAtmospheres.jl

---------

Co-authored-by: Navid C. Constantinou <[email protected]>

Author: glwagner

src/OceanSeaIceModels/InterfaceComputations/similarity_theory_turbulent_fluxes.jl

@@ -58,10 +58,10 @@ end
 
 """
     SimilarityTheoryFluxes(FT::DataType = Float64;
-                           gravitational_acceleration = convert(FT, 9.81),
-                           von_karman_constant = convert(FT, 0.4),
-                           turbulent_prandtl_number = convert(FT, 1),
-                           gustiness_parameter = convert(FT, 6.5),
+                           gravitational_acceleration = 9.81,
+                           von_karman_constant = 0.4,
+                           turbulent_prandtl_number = 1,
+                           gustiness_parameter = 1,
                            stability_functions = default_stability_functions(FT),
                            roughness_lengths = default_roughness_lengths(FT),
                            similarity_form = LogarithmicSimilarityProfile(),
@@ -77,7 +77,7 @@ Keyword Arguments
 
 - `von_karman_constant`: The von Karman constant. Default: 0.4.
 - `turbulent_prandtl_number`: The turbulent Prandtl number. Default: 1.
-- `gustiness_parameter`: The gustiness parameter that accounts for low wind speed areas. Default: 6.5.
+- `gustiness_parameter`: Increases surface fluxes in low wind conditions. Default: 1.
 - `stability_functions`: The stability functions. Default: `default_stability_functions(FT)` that follow the
                          formulation of Edson et al. (2013).
 - `roughness_lengths`: The roughness lengths used to calculate the characteristic scales for momentum, temperature and
@@ -90,7 +90,7 @@ Keyword Arguments
 function SimilarityTheoryFluxes(FT::DataType = Oceananigans.defaults.FloatType;
                                 von_karman_constant = 0.4,
                                 turbulent_prandtl_number = 1,
-                                gustiness_parameter = 6.5,
+                                gustiness_parameter = 1,
                                 stability_functions = edson_stability_functions(FT),
                                 roughness_lengths = default_roughness_lengths(FT),
                                 similarity_form = LogarithmicSimilarityProfile(),

src/OceanSeaIceModels/PrescribedAtmospheres.jl

@@ -343,6 +343,8 @@ function default_freshwater_flux(grid, times)
     return (; rain, snow)
 end
 
+""" The standard unit of atmospheric pressure; 1 standard atmosphere (atm) = 101,325 Pascals (Pa) in SI units.
+This is approximately equal to the mean sea-level atmospheric pressure on Earth. """
 function default_atmosphere_pressure(grid, times)
     pa = FieldTimeSeries{Center, Center, Nothing}(grid, times)
     parent(pa) .= 101325
@@ -371,7 +373,7 @@ end
     PrescribedAtmosphere(grid, times;
                          clock = Clock{Float64}(time = 0),
                          surface_layer_height = 10, # meters
-                         boundary_layer_height = 600 # meters,
+                         boundary_layer_height = 512 # meters,
                          thermodynamics_parameters = PrescribedAtmosphereThermodynamicsParameters(FT),
                          auxiliary_freshwater_flux = nothing,
                          velocities            = default_atmosphere_velocities(grid, times),
@@ -385,8 +387,8 @@ state with data given at `times`.
 """
 function PrescribedAtmosphere(grid, times;
                               clock = Clock{Float64}(time = 0),
-                              surface_layer_height = convert(eltype(grid), 10),
-                              boundary_layer_height = convert(eltype(grid), 600),
+                              surface_layer_height = 10,
+                              boundary_layer_height = 512,
                               thermodynamics_parameters = nothing,
                               auxiliary_freshwater_flux = nothing,
                               velocities            = default_atmosphere_velocities(grid, times),
@@ -422,7 +424,7 @@ end
 """
     TwoBandDownwellingRadiation(shortwave=nothing, longwave=nothing)
 
-Return a two-band model for downwelling radiation (split in a shortwave band
+Return a two-band model for downwelling radiation (split into a shortwave band
 and a longwave band) that passes through the atmosphere and arrives at the surface of ocean
 or sea ice.
 """
@@ -434,4 +436,3 @@ Adapt.adapt_structure(to, tsdr::TwoBandDownwellingRadiation) =
                                 adapt(to, tsdr.longwave))
 
 end # module
-