Merge branch 'main' into glw/better-nan-checker

Author: taimoorsohail

src/BoundaryConditions/fill_halo_regions_zipper.jl

@@ -77,6 +77,7 @@ end
 
     # We substitute the redundant part of the last row to ensure consistency
     @inbounds u[i, Ny, k] = ifelse(i > Nx ÷ 2, sign * u[i′, Ny, k], u[i, Ny, k])
+    
     return nothing
 end
 

src/Fields/field.jl

@@ -722,6 +722,10 @@ for reduction in (:sum, :maximum, :minimum, :all, :any, :prod)
     end
 end
 
+# Improve me! We can should both the extrama in one single reduction instead of two
+Base.extrema(c::AbstractField; kwargs...) = (minimum(c; kwargs...), maximum(c; kwargs...))
+Base.extrema(f, c::AbstractField; kwargs...) = (minimum(f, c; kwargs...), maximum(f, c; kwargs...))
+
 function Statistics._mean(f, c::AbstractField, ::Colon; condition = nothing, mask = 0)
     operator = condition_operand(f, c, condition, mask)
     return sum(operator) / conditional_length(operator)

src/MultiRegion/multi_region_field.jl

@@ -120,6 +120,9 @@ end
 set!(mrf::MultiRegionField, v)  = apply_regionally!(set!,  mrf, v)
 fill!(mrf::MultiRegionField, v) = apply_regionally!(fill!, mrf, v)
 
+set!(mrf::MultiRegionField, a::Number)  = apply_regionally!(set!,  mrf, a)
+fill!(mrf::MultiRegionField, a::Number) = apply_regionally!(fill!, mrf, a)
+
 set!(mrf::MultiRegionField, f::Function) = apply_regionally!(set!, mrf, f)
 set!(u::MultiRegionField, v::MultiRegionField) = apply_regionally!(set!, u, v)
 compute!(mrf::GriddedMultiRegionField, time=nothing) = apply_regionally!(compute!, mrf, time)

test/test_field.jl

@@ -92,6 +92,9 @@ function run_field_reduction_tests(FT, arch)
         @test maximum(abs, ϕ) ≈ maximum(abs, ϕ_vals) atol=ε
         @test mean(abs2, ϕ) ≈ mean(abs2, ϕ) atol=ε
 
+        @test extrema(ϕ) == (minimum(ϕ), maximum(ϕ))
+        @test extrema(∛, ϕ) == (minimum(∛, ϕ), maximum(∛, ϕ))
+
         for dims in dims_to_test
             @test all(isapprox(minimum(ϕ, dims=dims), minimum(ϕ_vals, dims=dims), atol=4ε))
             @test all(isapprox(maximum(ϕ, dims=dims), maximum(ϕ_vals, dims=dims), atol=4ε))
@@ -630,4 +633,4 @@ end
             @test_throws BoundsError cvvv[:, :, k_top-2:k_top]
         end
     end
-end
+end