Merge pull request #70 from ClickHouse/ncb/remove-asserts

bharatnc · web-flow · commit 210f686ab967 · 2025-04-17T13:12:14.000-07:00
remove debug table validation checks
diff --git a/cpp/src/arrow/table.cc b/cpp/src/arrow/table.cc
@@ -619,7 +619,6 @@ TableBatchReader::TableBatchReader(const Table& table)
   for (int i = 0; i < table.num_columns(); ++i) {
     column_data_[i] = table.column(i).get();
   }
-  DCHECK(table_.Validate().ok());
 }
 
 TableBatchReader::TableBatchReader(std::shared_ptr<Table> table)
@@ -633,7 +632,6 @@ TableBatchReader::TableBatchReader(std::shared_ptr<Table> table)
   for (int i = 0; i < owned_table_->num_columns(); ++i) {
     column_data_[i] = owned_table_->column(i).get();
   }
-  DCHECK(table_.Validate().ok());
 }
 
 std::shared_ptr<Schema> TableBatchReader::schema() const { return table_.schema(); }

Original file line number	Diff line number	Diff line change
`@@ -619,7 +619,6 @@ TableBatchReader::TableBatchReader(const Table& table)`
`619`	`619`	`for (int i = 0; i < table.num_columns(); ++i) {`
`620`	`620`	`column_data_[i] = table.column(i).get();`
`621`	`621`	`}`
`622`		`- DCHECK(table_.Validate().ok());`
`623`	`622`	`}`
`624`	`623`
`625`	`624`	`TableBatchReader::TableBatchReader(std::shared_ptr<Table> table)`
`@@ -633,7 +632,6 @@ TableBatchReader::TableBatchReader(std::shared_ptr<Table> table)`
`633`	`632`	`for (int i = 0; i < owned_table_->num_columns(); ++i) {`
`634`	`633`	`column_data_[i] = owned_table_->column(i).get();`
`635`	`634`	`}`
`636`		`- DCHECK(table_.Validate().ok());`
`637`	`635`	`}`
`638`	`636`
`639`	`637`	`std::shared_ptr<Schema> TableBatchReader::schema() const { return table_.schema(); }`