Commit 5130256
committed
chore(Icon stories): tighten ResponsiveGridContainer typing and apply prettier
Address Copilot review feedback on PR #1050: type ResponsiveGridContainer
as `ComponentProps<typeof GridContainer>` and merge className via `cn`
so callers can extend the wrapper without losing the responsive-grid
class.
Also runs prettier on the file to clear pre-existing code-quality CI
failures from the migration commit (one-line JSX expressions that
prettier wants on multiple lines). Auto-format, no behavior change.
The unaddressed Copilot point — `circle[fill]` appearing in both the
stroke and fill rules of Icon.module.css — is a pre-existing bug that
the migration deliberately preserved per the byte-for-byte parity rule
(`circle[stroke]` was missing from the original styled-components
source too). Fix in a separate PR after this lands.1 parent 9f430ea commit 5130256
1 file changed
Lines changed: 112 additions & 20 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
73 | 74 | | |
74 | 75 | | |
75 | 76 | | |
76 | | - | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
77 | 83 | | |
78 | 84 | | |
79 | 85 | | |
80 | | - | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
81 | 92 | | |
82 | 93 | | |
83 | 94 | | |
84 | | - | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
85 | 101 | | |
86 | 102 | | |
87 | 103 | | |
88 | | - | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
89 | 110 | | |
90 | 111 | | |
91 | 112 | | |
92 | | - | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
93 | 119 | | |
94 | 120 | | |
95 | 121 | | |
96 | | - | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
97 | 128 | | |
98 | 129 | | |
99 | 130 | | |
100 | | - | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
101 | 137 | | |
102 | 138 | | |
103 | 139 | | |
104 | | - | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
105 | 146 | | |
106 | 147 | | |
107 | 148 | | |
108 | | - | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
109 | 155 | | |
110 | 156 | | |
111 | 157 | | |
112 | | - | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
113 | 164 | | |
114 | 165 | | |
115 | 166 | | |
116 | | - | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
117 | 174 | | |
118 | 175 | | |
119 | 176 | | |
120 | | - | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
121 | 184 | | |
122 | 185 | | |
123 | 186 | | |
124 | | - | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
125 | 193 | | |
126 | 194 | | |
127 | 195 | | |
128 | | - | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
129 | 203 | | |
130 | 204 | | |
131 | 205 | | |
132 | | - | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
133 | 212 | | |
134 | 213 | | |
135 | 214 | | |
136 | | - | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
137 | 221 | | |
138 | 222 | | |
139 | 223 | | |
140 | | - | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
141 | 230 | | |
142 | 231 | | |
143 | 232 | | |
| |||
164 | 253 | | |
165 | 254 | | |
166 | 255 | | |
167 | | - | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
168 | 260 | | |
169 | | - | |
| 261 | + | |
170 | 262 | | |
171 | 263 | | |
172 | 264 | | |
| |||
0 commit comments