Skip to content

Commit 0f49408

Browse files
Apply suggestions from code review
Co-authored-by: Copilot <[email protected]> Signed-off-by: Joe S. <[email protected]>
1 parent cb157ed commit 0f49408

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ The supported method of passing ClickHouse server settings is to prefix such arg
2929
### Improvements
3030
- Add support for QBit data type. Closes [#570](https://github.com/ClickHouse/clickhouse-connect/issues/570)
3131
- Add the ability to create table from PyArrow objects. Addresses [#588](https://github.com/ClickHouse/clickhouse-connect/issues/588)
32-
- Always generate query_id from the client side as a UUID4 if it not explicitly set. Closes [#596](https://github.com/ClickHouse/clickhouse-connect/issues/596)
32+
- Always generate query_id from the client side as a UUID4 if it is not explicitly set. Closes [#596](https://github.com/ClickHouse/clickhouse-connect/issues/596)
3333

3434
## 0.10.0, 2025-11-14
3535

tests/integration_tests/test_client.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -448,7 +448,8 @@ def check_in_logs(test_query_id):
448448
max_retries = 30
449449
for _ in range(max_retries):
450450
log_result = test_client.query(
451-
f"SELECT query_id FROM system.query_log WHERE query_id = '{test_query_id}' AND " "event_time > now() - 30 LIMIT 1"
451+
"SELECT query_id FROM system.query_log WHERE query_id = {query_id} AND event_time > now() - 30 LIMIT 1",
452+
parameters={"query_id": test_query_id}
452453
)
453454

454455
if len(log_result.result_set) > 0:

0 commit comments

Comments
 (0)