Skip to content

Commit 94839e0

Browse files
author
Meir Elbaz
committed
add warning log when executor_threads and executor are used
1 parent bdb5a7c commit 94839e0

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

clickhouse_connect/driver/asyncclient.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import asyncio
22
import io
3+
import logging
34
import os
45
from concurrent.futures.thread import ThreadPoolExecutor
56
from datetime import tzinfo
@@ -14,6 +15,9 @@
1415
from clickhouse_connect.datatypes.base import ClickHouseType
1516
from clickhouse_connect.driver.insert import InsertContext
1617

18+
logger = logging.getLogger(__name__)
19+
20+
1721
class DefaultThreadPoolExecutor:
1822
pass
1923

@@ -43,6 +47,9 @@ def __init__(self,
4347
self.new_executor = True
4448
self.executor = ThreadPoolExecutor(max_workers=executor_threads)
4549
else:
50+
if executor_threads != 0:
51+
logger.warning('executor_threads parameter is ignored when passing an executor object')
52+
4653
self.new_executor = False
4754
self.executor = executor
4855

0 commit comments

Comments
 (0)