Merge pull request #248 from 1261385937/bugfix

bugfix, remove items_.reserve for batch write

Author: Enmk

clickhouse/columns/string.cpp

@@ -247,8 +247,8 @@ void ColumnString::Append(ColumnRef column) {
         // TODO: fill up existing block with some items and then add a new one for the rest of items
         if (blocks_.size() == 0 || blocks_.back().GetAvailable() < total_size)
             blocks_.emplace_back(std::max(DEFAULT_BLOCK_SIZE, total_size));
-        items_.reserve(items_.size() + col->Size());
 
+        // Intentionally not doing items_.reserve() since that cripples performance.
         for (size_t i = 0; i < column->Size(); ++i) {
             this->AppendUnsafe((*col)[i]);
         }