add golangci-lint

Author: cyrilou242

.github/workflows/run-tests.yml

@@ -13,6 +13,7 @@ on:
 
 jobs:
   test:
+    name: Tests
     runs-on: ubuntu-latest
     strategy:
       fail-fast: true
@@ -22,12 +23,17 @@ jobs:
           - "1.24"
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
       - name: Install Go ${{ matrix.go }}
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version: ${{ matrix.go }}
 
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v9
+        with:
+          version: v2.11
+
       - name: Run tests
         run: make

Makefile

@@ -13,6 +13,10 @@ vet:
 test:
 	go test ./...
 
+.PHONY: lint
+lint:
+	golangci-lint run
+
 .PHONY: build
 build:
 	go build -o bin/clickhouse-go-linter .

passes/chbatchclose/chbatchclose.go

@@ -64,7 +64,7 @@ func (b *batchUsage) report(varName string, pass *analysis.Pass) {
 		// no usage of rows.Next()
 		return
 	}
-	if !(b.deferredClose || b.returned) {
+	if !b.deferredClose && !b.returned {
 		pass.Reportf(b.assignPos,
 			"clickhouse Batch %s must be closed defensively with defer %s.Close() after successful instantiation",
 			varName, varName)