Commit 04601f9
fix(test-runner): consume in-repo @clickhouse/rowbinary via workspace (#923)
## Problem
`tests/clickhouse-test-runner` pinned `@clickhouse/rowbinary` to
`^0.1.2`, pulling the **published** parser from npm rather than the
in-repo `0.2.0`. CI and local runs therefore exercised the old decoder
behavior (notably enum decoding), invalidating the new RowBinary backend
coverage.
Building `0.2.0` surfaced a second issue the pin was masking: `0.2.0`
reorganized `dist/` into `readers/` and `writers/` subdirs (the recent
"split source by direction" change), so the test-runner's old flat
subpath imports (`@clickhouse/rowbinary/decimals`, `/core`, …) **no
longer resolve** under the new export map.
## Changes
- **Root `package.json`** — add `./skills/clickhouse-js-node-rowbinary`
to `workspaces` so npm symlinks the local package, exactly like
`@clickhouse/client` and `@clickhouse/datatype-parser`. The skill's
`node_modules` is gitignored and its standalone build is driven by its
own committed lockfile, so publishing the skill is unaffected.
- **test-runner `package.json`** — `@clickhouse/rowbinary: "^0.1.2"` →
`"*"` (matches the existing `@clickhouse/client` workspace reference).
- **7 import sites** (3 files) — flat subpaths → `readers/*`.
- `package-lock.json` regenerated: `node_modules/@clickhouse/rowbinary`
is now a workspace link; no `0.1.2` registry refs remain.
## Verification
- `npm install` links the local package ✓
- `datatype-parser`, `rowbinary`, `client` build ✓
- test-runner `typecheck` ✓, `build` ✓, `lint` ✓, **80/80 unit tests
pass** against the linked `0.2.0` ✓
## Note
`"*"` is correct while rowbinary is developed in-repo. Once it's
published at `0.2.0`+, consider re-pinning to a real semver range.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 4026dd8 commit 04601f9
7 files changed
Lines changed: 53 additions & 46 deletions
File tree
- skills/clickhouse-js-node-rowbinary
- tests/clickhouse-test-runner
- __tests__
- src
- backends
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
77 | | - | |
| 77 | + | |
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
| |||
Lines changed: 8 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
104 | | - | |
105 | | - | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
106 | 110 | | |
107 | 111 | | |
108 | 112 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
16 | 18 | | |
17 | 19 | | |
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
22 | 24 | | |
23 | | - | |
| 25 | + | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
| 1 | + | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
40 | 41 | | |
41 | 42 | | |
42 | 43 | | |
| |||
161 | 162 | | |
162 | 163 | | |
163 | 164 | | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | 165 | | |
176 | 166 | | |
177 | 167 | | |
| |||
201 | 191 | | |
202 | 192 | | |
203 | 193 | | |
204 | | - | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
205 | 198 | | |
206 | 199 | | |
207 | 200 | | |
| |||
0 commit comments