feat: support distroless images in ch version probe, remove keeper version probe job (#195)

Author: ashishch432

.github/workflows/ci.yaml

@@ -238,7 +238,7 @@ jobs:
             deploy_target: test-compat-e2e-olm
           - name: supported-clickhouse-compatibility
             k8s_image: v1.30.13
-            clickhouse_version: "26.5,26.4,26.3,25.8"
+            clickhouse_version: "26.5,26.5-distroless,26.4,26.3,25.8"
             deploy_target: test-compat-e2e-manifest
           - name: operator-upgrade
             k8s_image: v1.30.13

api/v1alpha1/conditions.go

@@ -40,7 +40,7 @@ const (
 	ConditionReasonConfigReloadFailed   ConditionReason = "ConfigReloadFailed"
 	ConditionReasonConfigReloadPending  ConditionReason = "ConfigReloadPending"
 
-	// ConditionTypeVersionInSync indicates that all replicas report the same version as the image.
+	// ConditionTypeVersionInSync indicates that all replicas report the same version.
 	ConditionTypeVersionInSync        ConditionType   = "VersionInSync"
 	ConditionReasonVersionMatch       ConditionReason = "VersionMatch"
 	ConditionReasonVersionMismatch    ConditionReason = "VersionMismatch"

api/v1alpha1/keepercluster_types.go

@@ -66,6 +66,8 @@ type KeeperClusterSpec struct {
 	UpgradeChannel string `json:"upgradeChannel,omitempty"`
 
 	// VersionProbeTemplate overrides for the version detection Job.
+	//
+	// Deprecated: Keeper version probe Jobs are not used; this field is retained for backward compatibility.
 	// +optional
 	VersionProbeTemplate *VersionProbeTemplate `json:"versionProbeTemplate,omitempty"`
 }
@@ -161,12 +163,13 @@ type KeeperClusterStatus struct {
 	// ObservedGeneration indicates latest generation observed by controller.
 	// +operator-sdk:csv:customresourcedefinitions:type=status
 	ObservedGeneration int64 `json:"observedGeneration,omitempty"`
-	// Version indicates the version reported by the container image.
+	// Version indicates the version reported by the Keeper server.
 	// +optional
 	// +operator-sdk:csv:customresourcedefinitions:type=status
 	Version string `json:"version,omitempty"`
 	// VersionProbeRevision is the image hash of the last successful version probe.
-	// When this matches the current image hash, the cached Version is used directly.
+	//
+	// Deprecated: Keeper version probe Jobs are not used; this field is retained for backward compatibility.
 	// +optional
 	// +operator-sdk:csv:customresourcedefinitions:type=status
 	VersionProbeRevision string `json:"versionProbeRevision,omitempty"`

config/crd/bases/clickhouse.com_keeperclusters.yaml

@@ -6163,8 +6163,10 @@ spec:
                 pattern: ^(lts|stable|\d+\.\d+)?$
                 type: string
               versionProbeTemplate:
-                description: VersionProbeTemplate overrides for the version detection
-                  Job.
+                description: |-
+                  VersionProbeTemplate overrides for the version detection Job.
+
+                  Deprecated: Keeper version probe Jobs are not used; this field is retained for backward compatibility.
                 properties:
                   metadata:
                     description: Metadata applied to the version probe Job.
@@ -6869,13 +6871,14 @@ spec:
                   spec revision.
                 type: string
               version:
-                description: Version indicates the version reported by the container
-                  image.
+                description: Version indicates the version reported by the Keeper
+                  server.
                 type: string
               versionProbeRevision:
                 description: |-
                   VersionProbeRevision is the image hash of the last successful version probe.
-                  When this matches the current image hash, the cached Version is used directly.
+
+                  Deprecated: Keeper version probe Jobs are not used; this field is retained for backward compatibility.
                 type: string
             type: object
         type: object

config/manifests/bases/clickhouse-operator.clusterserviceversion.yaml

@@ -141,12 +141,12 @@ spec:
           revision.
         displayName: Update Revision
         path: updateRevision
-      - description: Version indicates the version reported by the container image.
+      - description: Version indicates the version reported by the Keeper server.
         displayName: Version
         path: version
       - description: |-
           VersionProbeRevision is the image hash of the last successful version probe.
-          When this matches the current image hash, the cached Version is used directly.
+          Deprecated: Keeper version probe Jobs are not used; this field is retained for backward compatibility.
         displayName: Version Probe Revision
         path: versionProbeRevision
       version: v1alpha1

dist/chart-cluster/values.yaml

@@ -162,5 +162,7 @@ keeper:
     # upgradeChannel: ""
 
     # VersionProbeTemplate overrides for the version detection Job.
+    #
+    # Deprecated: Keeper version probe Jobs are not used; this field is retained for backward compatibility.
     # versionProbeTemplate: {}
 

dist/chart/templates/crd/keeperclusters.clickhouse.com.yaml

@@ -6166,8 +6166,10 @@ spec:
                 pattern: ^(lts|stable|\d+\.\d+)?$
                 type: string
               versionProbeTemplate:
-                description: VersionProbeTemplate overrides for the version detection
-                  Job.
+                description: |-
+                  VersionProbeTemplate overrides for the version detection Job.
+
+                  Deprecated: Keeper version probe Jobs are not used; this field is retained for backward compatibility.
                 properties:
                   metadata:
                     description: Metadata applied to the version probe Job.
@@ -6872,13 +6874,14 @@ spec:
                   spec revision.
                 type: string
               version:
-                description: Version indicates the version reported by the container
-                  image.
+                description: Version indicates the version reported by the Keeper
+                  server.
                 type: string
               versionProbeRevision:
                 description: |-
                   VersionProbeRevision is the image hash of the last successful version probe.
-                  When this matches the current image hash, the cached Version is used directly.
+
+                  Deprecated: Keeper version probe Jobs are not used; this field is retained for backward compatibility.
                 type: string
             type: object
         type: object