Panic: Invalid memory address crash

[jorgeparavicini]

I'm using CDKTF with the ClickHouse DBOps v1.60-alpha1 version. When deploying a stack which creates some roles with grants it crashes with the following error message:

Stack trace from the terraform-provider-clickhousedbops_v1.6.0-alpha1 plugin:

                       panic: runtime error: invalid memory address or nil pointer dereference
                       [signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x1051c756c]

                       goroutine 341 [running]:
                       github.com/ClickHouse/terraform-provider-clickhousedbops/pkg/resource/user.(*Resource).Create(0x14000798e40, {0x1056f7d78, 0x14000797dd0}, {{{{0x1056ff3b0, 0x14000614c00}, {0x1055760a0, 0x140006149f0}}, {0x105705518, 0x14000d004b0}}, {{{0x1056ff3b0, ...}, ...}, ...}, ...}, ...)
                        github.com/ClickHouse/terraform-provider-clickhousedbops/pkg/resource/user/user.go:219 +0x54c
                       github.com/hashicorp/terraform-plugin-framework/internal/fwserver.(*Server).CreateResource(0x1400025c308, {0x1056f7d78, 0x14000797dd0}, 0x140006f34c0, 0x140006f3490)
                        github.com/hashicorp/terraform-plugin-framework@v1.16.1/internal/fwserver/server_createresource.go:127 +0x644
prod-clickhouse-users  github.com/hashicorp/terraform-plugin-framework/internal/fwserver.(*Server).ApplyResourceChange(0x1400025c308, {0x1056f7d78, 0x14000797dd0}, 0x140001fd0a0, 0x140006f35e8)
                        github.com/hashicorp/terraform-plugin-framework@v1.16.1/internal/fwserver/server_applyresourcechange.go:63 +0x434
                       github.com/hashicorp/terraform-plugin-framework/internal/proto6server.(*Server).ApplyResourceChange(0x1400025c308, {0x1056f7d78?, 0x14000797ce0?}, 0x140003bfd10)
                        github.com/hashicorp/terraform-plugin-framework@v1.16.1/internal/proto6server/server_applyresourcechange.go:71 +0x430
                       github.com/hashicorp/terraform-plugin-go/tfprotov6/tf6server.(*server).ApplyResourceChange(0x1400024bae0, {0x1056f7d78?, 0x140007974a0?}, 0x14000483980)
                        github.com/hashicorp/terraform-plugin-go@v0.29.0/tfprotov6/tf6server/server.go:944 +0x294
                       github.com/hashicorp/terraform-plugin-go/tfprotov6/internal/tfplugin6._Provider_ApplyResourceChange_Handler({0x1056cdae0, 0x1400024bae0}, {0x1056f7d78, 0x140007974a0}, 0x14000483900, 0x0)
                        github.com/hashicorp/terraform-plugin-go@v0.29.0/tfprotov6/internal/tfplugin6/tfplugin6_grpc.pb.go:789 +0x1c0
prod-clickhouse-users  google.golang.org/grpc.(*Server).processUnaryRPC(0x14000246200, {0x1056f7d78, 0x140007973e0}, 0x14000c08600, 0x140002b3e60, 0x105f66fa8, 0x0)
                        google.golang.org/grpc@v1.76.0/server.go:1431 +0xc9c
                       google.golang.org/grpc.(*Server).handleStream(0x14000246200, {0x1056f89c8, 0x1400041c000}, 0x14000c08600)
                        google.golang.org/grpc@v1.76.0/server.go:1842 +0x900
                       google.golang.org/grpc.(*Server).serveStreams.func2.1()
                        google.golang.org/grpc@v1.76.0/server.go:1061 +0x84
                       created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 23
                        google.golang.org/grpc@v1.76.0/server.go:1072 +0x138

                       Error: The terraform-provider-clickhousedbops_v1.6.0-alpha1 plugin crashed!

                       This is always indicative of a bug within the plugin. It would be immensely
                       helpful if you could report the crash with the plugin's maintainers so that it
                       can be fixed. The output above should help diagnose the issue.

I'm unsure what data would be relevant, i'd be happy to provide additional information

[nunoadrego]

Thanks for the report @jorgeparavicini . Our team will take a look.

[nunoadrego]

@jorgeparavicini can you see if the latest alpha version fixes the issue? - v1.8.0-alpha1

[jorgeparavicini]

@nunoadrego, it seems the crash no longer occurs, but it's hard to verify 100% since it happened intermittently. However, when granting certain privileges, we used to get the issue described in #105, now we are getting the following error:

Could not create privilege grant, unexpected error: grant privilege "SHOW to
role admin" was created but could not be retrieved within timeout (30s):
context deadline exceeded

[nunoadrego]

@jorgeparavicini, can you provide details on the cluster setup (size, configuration) and/or a way to reproduce it?

That new error means it reaches the default timeout we set. Does it succeed on a second attempt? We can make the timeout configurable for that resource. We already provide that for setting resource.

[jorgeparavicini]

Hi @nunoadrego, it's hard to provide a way to reproduce it, as i'm not sure what causes it. However, we use ClickHouse Cloud with 3 replicas each using 16 GiB memory and 4vCPU. I will try and see if increasing the setting has an effect once I find some time for it

[nunoadrego]

Hi @jorgeparavicini . The existing configurable timeout I mentioned is for another resource (settings), not for grantprivilege. We need to implement it if we reach the conclusion that this is a delay issue.

Can you provide the IaC snippet that's causing the grant privileges issue (clickhousedbops_grant_privilege and clickhousedbops_role resources, I assume)?