Skip to content

Commit 267b60b

Browse files
committed
added todo in area's of code smell
1 parent fbf326b commit 267b60b

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

backend/preprocessing/preprocessor.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,7 @@ def _process_single_chunk(
198198
Thread-safe for parallel execution.
199199
Returns None if processing fails.
200200
"""
201+
#TODO: Specifcy explicit return type and not just a dict in docstring
201202
try:
202203
# Extract frames with complexity analysis
203204
frames, sampling_fps, complexity_score = self.extractor.extract_frames(video_path, chunk)
@@ -230,6 +231,7 @@ def _process_single_chunk(
230231
complexity_score=complexity_score
231232
)
232233

234+
#TODO: Turn this into a dataclass or specific type
233235
return {
234236
'chunk_id': chunk.chunk_id,
235237
'frames': compressed_frames,
@@ -269,8 +271,10 @@ def _create_metadata(
269271
)
270272

271273
def get_stats(self, processed_chunks: List[Dict[str, Any]]) -> Dict[str, Any]:
274+
# TODO: Improve docstring and be explicit about parameter and return types
272275
"""Calculate aggregate statistics from processed chunks."""
273276
if not processed_chunks:
277+
# TODO: Turn this into a dataclass
274278
return {
275279
'total_chunks': 0,
276280
'total_frames': 0,
@@ -290,6 +294,7 @@ def get_stats(self, processed_chunks: List[Dict[str, Any]]) -> Dict[str, Any]:
290294
complexities = [c['metadata']['complexity_score'] for c in processed_chunks]
291295
fps_values = [c['metadata']['sampling_fps'] for c in processed_chunks]
292296

297+
# TODO: Turn this into a dataclass
293298
return {
294299
'total_chunks': len(processed_chunks),
295300
'total_frames': total_frames,

0 commit comments

Comments
 (0)