This repository was archived by the owner on Jul 6, 2020. It is now read-only.
This repository was archived by the owner on Jul 6, 2020. It is now read-only.
Add option to change leader-board decimal precision #284
Description
Add option under settings tab in challenge page to change leader-board decimal precision by challenge host (Note: settings tab is only for the host user).
It is expected to add the front-end to be able to show the current leaderbord decimal precision
value (refer field here) and to add the option to change this field by the host user.
Activity
Suryansh5545 commentedon Feb 8, 2020
This was a GCI task and the problem faced by the student was that they were able to find how precision value is changed or defined so. For those who will attempt this you can find the precision value here https://github.com/Cloud-CV/EvalAI-ngx/blob/master/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.html#L114 this value is currently statically applied.
Abhi58 commentedon Feb 8, 2020
Hi @Sanji515 @Suryansh5545 . I would like to take up this issue. Please assign this to me. Thanks!
Sanji515 commentedon Feb 8, 2020
Sure @Abhi58 You can work on it.
Abhi58 commentedon Feb 8, 2020
Hi @Sanji515 . I was going through the code of EvalAI. There i found a variable called 'leaderboard_decimal_precision' which i believe is a part of callback response data on line 1437 in controller.js. I searched for the variable in the controller file, but couldn't find it.
Abhi58 commentedon Feb 8, 2020
Could you tell me from where is the response coming from? Thanks!
Sanji515 commentedon Feb 8, 2020
@Abhi58 I didn't get exactly of which controller.js file you are pointing line 1437. But you can take a look at this API here
Abhi58 commentedon Feb 8, 2020
Sure @Sanji515 . Thanks!
Abhi58 commentedon Feb 8, 2020
Hi @Sanji515 . I ran the EvalAI-ngx using ng serve because docker-compose up was giving errors. So, based on EvalAI code and the assumption that the backend is same for EvalAI and ngx i have made some changes.
Abhi58 commentedon Feb 8, 2020
I am not able to test my code since the backend server is not running. I will create a work in progress PR. Please verify it and let me know if the issue has been resolved. Sorry for the trouble! Thanks!
Suryansh5545 commentedon Feb 8, 2020
@Abhi58 What problem are you facing?
Suryansh5545 commentedon Feb 8, 2020
@Abhi58 I think you can edit the precision value here https://github.com/Cloud-CV/EvalAI-ngx/blob/master/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.html#L114 also if your docker setup can't run angular container then you can try to keep both backend and frontend started on two terminals.
Abhi58 commentedon Feb 8, 2020
Hi @Suryansh5545 . Backend was not running. That's the problem i was facing. As you suggested i will try to run on two terminals.
10 remaining items