Fix #4414: Reject invalid submission file types#5093
Open
officialasishkumar wants to merge 1 commit into
Open
Conversation
Reject uploaded files and file_url submissions whose extension is not allowed by the challenge phase so invalid artifacts are not queued for evaluation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4414.
Summary:
file_urlsubmissions after URL validation and before queueing evaluation work.Validation:
git diff --checkblack --check apps/jobs/views.py tests/unit/jobs/test_views.pyisort --check-only apps/jobs/views.py tests/unit/jobs/test_views.pydocker compose run django pytest tests/unit/jobs/test_views.py::BaseAPITestClass::test_challenge_submission_rejects_disallowed_upload_file_type tests/unit/jobs/test_views.py::BaseAPITestClass::test_challenge_submission_rejects_disallowed_file_url_type