Reviw suggestions

Author: PaulRalnikov

source/flow/tcp/tahoe/tcp_tahoe_cc.cpp

@@ -3,8 +3,8 @@
 #include <spdlog/fmt/fmt.h>
 
 namespace sim {
-TcpTahoeCC::TcpTahoeCC(TimeNs a_dealay_threshold, double a_sstresh)
-    : m_delay_threshold(a_dealay_threshold),
+TcpTahoeCC::TcpTahoeCC(TimeNs a_delay_threshold, double a_sstresh)
+    : m_delay_threshold(a_delay_threshold),
       m_ssthresh(a_sstresh),
       m_cwnd(1.0) {}
 
@@ -28,7 +28,7 @@ TimeNs TcpTahoeCC::get_pacing_delay() const { return TimeNs(0); }
 double TcpTahoeCC::get_cwnd() const { return m_cwnd; }
 
 std::string TcpTahoeCC::to_string() const {
-    return fmt::format("[delay threshold: {}, cwnd: {}, sstresh: {}]",
+    return fmt::format("[delay threshold: {}, cwnd: {}, ssthresh: {}]",
                        m_delay_threshold.value(), m_cwnd, m_ssthresh);
 }
 

source/flow/tcp/tahoe/tcp_tahoe_cc.hpp

@@ -4,7 +4,7 @@
 namespace sim {
 class TcpTahoeCC : public ITcpCC {
 public:
-    TcpTahoeCC(TimeNs a_dealay_threshold = TimeNs(4000), double a_sstresh = 8);
+    TcpTahoeCC(TimeNs a_delay_threshold = TimeNs(4000), double a_ssthresh = 8);
     ~TcpTahoeCC() = default;
 
     bool on_ack(TimeNs rtt, bool ecn_flag) final;

source/parser/parse_utils.cpp

@@ -39,5 +39,5 @@ SizeByte parse_buffer_size(const std::string &buffer_size) {
     if (unit == "B") {
         return SizeByte(value);
     }
-    throw std::runtime_error("Unsupported latency unit: " + unit);
+    throw std::runtime_error("Unsupported buffer size unit: " + unit);
 }

source/parser/parse_utils.hpp

@@ -13,7 +13,7 @@ SpeedGbps parse_speed(const std::string& throughput);
 TimeNs parse_latency(const std::string& latency);
 SizeByte parse_buffer_size(const std::string& buffer_size);
 
-// Parses node[field_name] using value_parser if node contains filed_name;
+// Parses node[field_name] using value_parser if node contains field_name;
 // Returns default_value otherwise
 template <typename T>
 T parse_with_default(const YAML::Node& node, std::string_view field_name,
@@ -22,7 +22,7 @@ T parse_with_default(const YAML::Node& node, std::string_view field_name,
     if (!node[field_name]) {
         LOG_WARN(
             fmt::format("{} does not set ; use default value", field_name));
-        return default_value;
+        return std::forward<T>(default_value);
     }
     return value_parser(node[field_name].as<std::string>());
 }

source/units/ld_comparation.hpp

@@ -3,5 +3,5 @@
 
 constexpr bool equal(long double value_1, long double value_2) {
     constexpr long double EPS = 1e-6;
-    return abs(value_1 - value_2) < EPS;
+    return std::abs(value_1 - value_2) < EPS;
 }

source/units/speed.hpp

@@ -28,6 +28,8 @@ class Speed {
         return equal(m_bit_per_ns, speed.value_bit_per_ns());
     }
 
+    constexpr bool operator!=(ThisSpeed speed) { return !(*this == speed); }
+
 private:
     long double m_bit_per_ns;  // value in bit per nanosecond
 };

source/units/time.hpp

@@ -61,7 +61,7 @@ class Time {
         return Time<Nanosecond>(m_value_ns * mult);
     }
 
-    constexpr ThisTime operator++() {
+    constexpr ThisTime& operator++() {
         m_value_ns += TTimeBase::to_nanoseconds_multiplier;
         return *this;
     }