Skip to content

Commit af941d3

Browse files
authored
Merge pull request #1958 from oalbrigt/build-dont-build-powervs-subnet-missing-deps
build: dont build powervs-subnet if dependencies are missing
2 parents 69e834d + 277370f commit af941d3

3 files changed

Lines changed: 17 additions & 2 deletions

File tree

configure.ac

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -519,6 +519,8 @@ fi
519519

520520
AC_PYTHON_MODULE(json)
521521
AC_PYTHON_MODULE(pyroute2)
522+
AC_PYTHON_MODULE(requests)
523+
AC_PYTHON_MODULE(urllib3)
522524

523525
AS_VERSION_COMPARE([$PYTHON_VERSION], [3.6], [BUILD_OCF_PY=0], [BUILD_OCF_PY=1], [BUILD_OCF_PY=1])
524526

@@ -557,6 +559,13 @@ if test -z "$PYTHON" || test $BUILD_OCF_PY -eq 0; then
557559
fi
558560
AM_CONDITIONAL(BUILD_GCP_VPC_MOVE_VIP, test $BUILD_GCP_VPC_MOVE_VIP -eq 1)
559561

562+
BUILD_POWERVS_SUBNET=1
563+
if test -z "$PYTHON" || test $BUILD_OCF_PY -eq 0 || test "x${HAVE_PYMOD_REQUESTS}" != xyes || test "x${HAVE_PYMOD_URLLIB3}" != xyes; then
564+
BUILD_POWERVS_SUBNET=0
565+
AC_MSG_WARN("Not building powervs-subnet")
566+
fi
567+
AM_CONDITIONAL(BUILD_POWERVS_SUBNET, test $BUILD_POWERVS_SUBNET -eq 1)
568+
560569
AC_PATH_PROGS(ROUTE, route)
561570
AC_DEFINE_UNQUOTED(ROUTE, "$ROUTE", path to route command)
562571

doc/man/Makefile.am

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,6 @@ man_MANS = ocf_heartbeat_AoEtarget.7 \
190190
ocf_heartbeat_portblock.7 \
191191
ocf_heartbeat_postfix.7 \
192192
ocf_heartbeat_pound.7 \
193-
ocf_heartbeat_powervs-subnet.7 \
194193
ocf_heartbeat_proftpd.7 \
195194
ocf_heartbeat_rabbitmq-cluster.7 \
196195
ocf_heartbeat_rabbitmq-server-ha.7 \
@@ -238,6 +237,10 @@ if BUILD_GCP_VPC_MOVE_VIP
238237
man_MANS += ocf_heartbeat_gcp-vpc-move-vip.7
239238
endif
240239

240+
if BUILD_POWERVS_SUBNET
241+
man_MANS += ocf_heartbeat_powervs-subnet.7
242+
endif
243+
241244
xmlfiles = $(man_MANS:.7=.xml)
242245

243246
%.1 %.5 %.7 %.8: %.xml

heartbeat/Makefile.am

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,6 @@ ocf_SCRIPTS = AoEtarget \
162162
portblock \
163163
postfix \
164164
pound \
165-
powervs-subnet \
166165
proftpd \
167166
rabbitmq-cluster \
168167
rabbitmq-server-ha \
@@ -207,6 +206,10 @@ if BUILD_GCP_VPC_MOVE_VIP
207206
ocf_SCRIPTS += gcp-vpc-move-vip
208207
endif
209208

209+
if BUILD_POWERVS_SUBNET
210+
ocf_SCRIPTS += powervs-subnet
211+
endif
212+
210213
ocfcommondir = $(OCF_LIB_DIR_PREFIX)/heartbeat
211214
ocfcommon_DATA = ocf-shellfuncs \
212215
ocf-binaries \

0 commit comments

Comments
 (0)