Handle status updates for switches

Author: CoMPaTech

README.md

@@ -28,7 +28,9 @@ Additional the setup flow will ask you for your username (i.e. e-mail address) a
 
 In the current state it retrieves `bike`, `status` and `position` from the API every 10 minutes.
 
-There is an early implementation on toggling data on your bike, `light` and `lock` can be adjusted.
+**BETA** There is an early implementation on toggling data on your bike, `light` and `lock` can be adjusted.
+Do note that the switches do not immediately reflect the status (i.e. they will when you toggle them, but switch back quickly).
+After your 'switch' command we do request an API update to check on the status, pending that update the switch might toggle back-n-forth some time.
 
 ## If you want more frequent updates
 

custom_components/stromer/binary_sensor.py

@@ -69,8 +69,6 @@ class StromerBinarySensor(StromerEntity, BinarySensorEntity):
     """Representation of a Binary Sensor."""
 
     _attr_has_entity_name = True
-    _attr_name = None
-    _attr_translation_key = DOMAIN
 
     entity_description = StromerBinarySensorEntityDescription
 

custom_components/stromer/manifest.json

@@ -8,5 +8,5 @@
   "iot_class": "cloud_polling",
   "issue_tracker": "https://github.com/CoMPaTech/stromer/issues",
   "requirements": [],
-  "version": "0.3.0a6"
+  "version": "0.3.0a7"
 }

custom_components/stromer/sensor.py

@@ -187,8 +187,6 @@ class StromerSensor(StromerEntity, SensorEntity):
     """Representation of a Sensor."""
 
     _attr_has_entity_name = True
-    _attr_name = None
-    _attr_translation_key = DOMAIN
 
     entity_description = SensorEntityDescription
 

custom_components/stromer/switch.py

@@ -10,6 +10,7 @@
     SwitchEntity,
     SwitchEntityDescription,
 )
+from homeassistant.core import callback
 
 from .const import DOMAIN, LOGGER
 from .entity import StromerEntity
@@ -48,8 +49,6 @@ class StromerSwitch(StromerEntity, SwitchEntity):
     """Representation of a Switch."""
 
     _attr_has_entity_name = True
-    _attr_name = None
-    _attr_translation_key = DOMAIN
 
     entity_description: SwitchEntityDescription
 
@@ -68,23 +67,28 @@ def __init__(
         device_id = coordinator.data.bike_id
 
         self.entity_description = description
-        self._attr_unique_id = f"{device_id}-{description.key}"
+        self._attr_unique_id = f"{device_id}-{description.key}-sw"
 
-    @property
-    def is_on(self) -> bool:
-        """Return True if entity is on."""
-        return self._coordinator.data.bikedata.get(self._ent)
+    @callback
+    def _handle_coordinator_update(self) -> None:
+        """Handle updated data from the coordinator."""
+        self._attr_is_on = self._coordinator.data.bikedata.get(self._ent)
+        self.async_write_ha_state()
 
     async def async_turn_on(self, **kwargs: Any) -> None:
         """Turn the device on."""
         if self.entity_description.key == "lock_flag":
             await self._coordinator.stromer.stromer_call_lock(True)
         if self.entity_description.key == "light_on":
             await self._coordinator.stromer.stromer_call_light("on")
+        # Call update on the bike so `is_on` correctly reflects status
+        await self._coordinator.async_request_refresh()
 
     async def async_turn_off(self, **kwargs: Any) -> None:
         """Turn the device off."""
         if self.entity_description.key == "lock_flag":
             await self._coordinator.stromer.stromer_call_lock(False)
         if self.entity_description.key == "light_on":
             await self._coordinator.stromer.stromer_call_light("off")
+        # Call update on the bike so `is_on` correctly reflects status
+        await self._coordinator.async_request_refresh()