Skip to content

Commit a5cea47

Browse files
committed
feat:remove some useless code
1 parent 78f9507 commit a5cea47

15 files changed

Lines changed: 78 additions & 172 deletions

File tree

app/index_platform/trie/init.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,15 @@ import (
2121
"github.com/CocaineCong/tangseng/pkg/trie"
2222
)
2323

24-
var GobalTrieTree *trie.Trie
24+
var GlobalTrieTree *trie.Trie
2525

2626
func InitTrieTree() {
27-
// GobalTrieTree = trie.NewTrie()
27+
// GlobalTrieTree = trie.NewTrie()
2828
// TODO: 这里的想法是把原始的读出来合并的,但是第一次读的时候由于是空的,所以会强制报错,用recover也不起作用,后面看看怎么处理吧... :-(
2929
// val, err := storage.GlobalTrieDBs.GetTrieTreeInfo()
3030
// if err != nil {
3131
// // 第一次读取会出现没有的情况
3232
// } else {
33-
// GobalTrieTree.Merge(val)
33+
// GlobalTrieTree.Merge(val)
3434
// }
3535
}

pkg/ctl/ctl.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,17 @@ package ctl
2020
import (
2121
"time"
2222

23-
"github.com/CocaineCong/tangseng/pkg/tracing"
2423
"github.com/gin-gonic/gin"
2524

25+
"github.com/CocaineCong/tangseng/pkg/tracing"
26+
2627
e2 "github.com/CocaineCong/tangseng/consts/e"
2728
)
2829

30+
const (
31+
defaultSuccessMsg = "操作成功"
32+
)
33+
2934
// Response 基础序列化器
3035
type Response struct {
3136
Status int `json:"status"`
@@ -44,7 +49,7 @@ func RespSuccess(ctx *gin.Context, data interface{}, code ...int) *Response {
4449
}
4550

4651
if data == nil {
47-
data = "操作成功"
52+
data = defaultSuccessMsg
4853
}
4954

5055
r := &Response{

pkg/jwt/jwt.go

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,16 @@ package jwt
2020
import (
2121
"time"
2222

23-
"github.com/pkg/errors"
24-
2523
"github.com/dgrijalva/jwt-go"
24+
"github.com/pkg/errors"
2625

2726
"github.com/CocaineCong/tangseng/consts"
2827
)
2928

29+
const (
30+
defaultIssuer = "Tangseng-search-engine"
31+
)
32+
3033
var jwtSecret = []byte("38324-search-engine") // TODO 从配置文件读取
3134

3235
type Claims struct {
@@ -45,7 +48,7 @@ func GenerateToken(id int64, username string) (accessToken, refreshToken string,
4548
Username: username,
4649
StandardClaims: jwt.StandardClaims{
4750
ExpiresAt: expireTime.Unix(),
48-
Issuer: "mall",
51+
Issuer: defaultIssuer,
4952
},
5053
}
5154
// 加密并获得完整的编码后的字符串token
@@ -56,7 +59,7 @@ func GenerateToken(id int64, username string) (accessToken, refreshToken string,
5659

5760
refreshToken, err = jwt.NewWithClaims(jwt.SigningMethodHS256, jwt.StandardClaims{
5861
ExpiresAt: rtExpireTime.Unix(),
59-
Issuer: "search-engine",
62+
Issuer: defaultIssuer,
6063
}).SignedString(jwtSecret)
6164
if err != nil {
6265
return "", "", errors.Wrap(err, "failed to get refreshToken")

pkg/kfk/consume/forward_index.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,8 @@ import (
2525
"sync"
2626
"syscall"
2727

28-
"github.com/pkg/errors"
29-
3028
"github.com/IBM/sarama"
29+
"github.com/pkg/errors"
3130

3231
"github.com/CocaineCong/tangseng/app/index_platform/repository/db/dao"
3332
"github.com/CocaineCong/tangseng/config"
@@ -117,7 +116,7 @@ func toggleConsumptionFlow(client sarama.ConsumerGroup, isPaused *bool) {
117116
*isPaused = !*isPaused
118117
}
119118

120-
// Consumer Sarama消费者群体的消费者
119+
// ForwardIndexConsumer Sarama消费者群体的消费者
121120
type ForwardIndexConsumer struct {
122121
Ready chan bool
123122
}

pkg/kfk/consume/trie_tree.go

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ func (consumer *TrieTreeConsumer) Cleanup(sarama.ConsumerGroupSession) error {
8888
// ConsumeClaim 必须启动 ConsumerGroupClaim 的 Messages() 消费者循环。
8989
// 一旦 Messages() 通道关闭,处理程序必须完成其处理循环并退出。
9090
func (consumer *TrieTreeConsumer) ConsumeClaim(session sarama.ConsumerGroupSession, claim sarama.ConsumerGroupClaim) error {
91-
// ctx := context.Background()
9291
gapTime := 2 * time.Minute
9392
for {
9493
select {
@@ -98,14 +97,12 @@ func (consumer *TrieTreeConsumer) ConsumeClaim(session sarama.ConsumerGroupSessi
9897
return nil
9998
}
10099
// 构建trie tree树
101-
trie.GobalTrieTree.Insert(string(message.Value))
102-
// logs.LogrusObj.Infof("TrieTreeConsumer Message claimed: value = %s, timestamp = %v, topic = %s", string(message.Value), message.Timestamp, message.Topic)
100+
trie.GlobalTrieTree.Insert(string(message.Value))
103101
session.MarkMessage(message, "")
104-
// https://github.com/IBM/sarama/issues/1192
105102

106103
case <-time.After(gapTime):
107104
logs.LogrusObj.Infof("ConsumeClaim starting store dict")
108-
// _ = storage.GlobalTrieDBs.StorageDict(trie.GobalTrieTree) // TODO:后续看看能不能实现一个全局的triedb,每次都先读取存量进行初始化,再插入增量...
105+
// _ = storage.GlobalTrieDBs.StorageDict(trie.GlobalTrieTree) // TODO:后续看看能不能实现一个全局的triedb,每次都先读取存量进行初始化,再插入增量...
109106
logs.LogrusObj.Infof("ConsumeClaim ending store dict")
110107

111108
case <-session.Context().Done():
@@ -116,12 +113,12 @@ func (consumer *TrieTreeConsumer) ConsumeClaim(session sarama.ConsumerGroupSessi
116113
}
117114

118115
// func mergeTrieTree(node string) {
119-
// trie.GobalTrieTree.Insert(node)
116+
// trie.GlobalTrieTree.Insert(node)
120117
// gapTime := 2 * time.Minute
121118
// for {
122119
// select {
123120
// case <-time.After(gapTime):
124-
// _ = storage.GlobalTrieDBs.StorageDict(trie.GobalTrieTree)
121+
// _ = storage.GlobalTrieDBs.StorageDict(trie.GlobalTrieTree)
125122
// }
126123
// }
127124
// }

pkg/kfk/init.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,14 @@
1818
package kfk
1919

2020
import (
21-
logs "github.com/CocaineCong/tangseng/pkg/logger"
2221
"github.com/IBM/sarama"
2322

23+
logs "github.com/CocaineCong/tangseng/pkg/logger"
24+
2425
"github.com/CocaineCong/tangseng/config"
2526
)
2627

27-
var GobalKafka sarama.Client
28+
var GlobalKafka sarama.Client
2829

2930
func InitKafka() {
3031
con := sarama.NewConfig()
@@ -34,5 +35,5 @@ func InitKafka() {
3435
logs.LogrusObj.Errorln(err)
3536
return
3637
}
37-
GobalKafka = kafkaClient
38+
GlobalKafka = kafkaClient
3839
}

pkg/kfk/produce.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,13 @@ package kfk
2020
import (
2121
_ "net/http/pprof"
2222

23-
"github.com/pkg/errors"
24-
2523
"github.com/IBM/sarama"
24+
"github.com/pkg/errors"
2625
)
2726

2827
// KafkaProducer 发送单条
2928
func KafkaProducer(topic string, msg []byte) (err error) {
30-
producer, err := sarama.NewSyncProducerFromClient(GobalKafka)
29+
producer, err := sarama.NewSyncProducerFromClient(GlobalKafka)
3130
if err != nil {
3231
return errors.Wrap(err, "failed to create Kafka producer")
3332
}
@@ -44,7 +43,7 @@ func KafkaProducer(topic string, msg []byte) (err error) {
4443

4544
// KafkaProducers 发送多条,topic在messages中
4645
func KafkaProducers(messages []*sarama.ProducerMessage) (err error) {
47-
producer, err := sarama.NewSyncProducerFromClient(GobalKafka)
46+
producer, err := sarama.NewSyncProducerFromClient(GlobalKafka)
4847
if err != nil {
4948
return errors.Wrap(err, "failed to create Kafka producer")
5049
}

pkg/res/response.go

Lines changed: 0 additions & 95 deletions
This file was deleted.

pkg/retry/retry.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,22 +31,22 @@ const (
3131
DefaultGapTime = 3 * time.Second // 默认的超时时间间隔
3232
)
3333

34-
var instance *RetryOption
34+
var instance *Option
3535
var once sync.Once
3636

3737
type DelayRetryFunc func(context.Context, interface{}) (interface{}, bool, error)
3838

39-
type RetryOption struct {
39+
type Option struct {
4040
GapTime time.Duration // 重试间隔时间
4141
RetryCount int // 重试次数
4242
RetryFunc DelayRetryFunc // 重试函数
4343

4444
ctx context.Context
4545
}
4646

47-
func NewRetryOption(ctx context.Context, gapTime time.Duration, retryCount int, func_ DelayRetryFunc) *RetryOption {
47+
func NewRetryOption(ctx context.Context, gapTime time.Duration, retryCount int, func_ DelayRetryFunc) *Option {
4848
once.Do(func() {
49-
instance = &RetryOption{
49+
instance = &Option{
5050
GapTime: gapTime,
5151
RetryCount: retryCount,
5252
RetryFunc: func_,
@@ -57,7 +57,7 @@ func NewRetryOption(ctx context.Context, gapTime time.Duration, retryCount int,
5757
return instance
5858
}
5959

60-
func (r *RetryOption) Retry(ctx context.Context, req interface{}) (resp interface{}, err error) {
60+
func (r *Option) Retry(ctx context.Context, req interface{}) (resp interface{}, err error) {
6161
if r.RetryFunc == nil {
6262
return resp, errors.Wrap(errors.New("RetryFunc is nil"), "failed to retry")
6363
}

0 commit comments

Comments
 (0)