delete the file_reference from group not working as expected

[EzimetYusup]

Hi there!
my scenario is I have a group, which has duplicated(path,display_name, and real_path are same but only uuid is different) file_reference, I loop through the group.files then put the duplicated file_reference to the array, then loop through the array then delete them from group

duplicated.each do |f|
            # group.files.delete(f)
            puts "deleting #{f.path} from #{group}"
            group.children.delete(f)
end

but when I save the project I found that the both file were deleted from group.
thanks!

[EzimetYusup]

@segiddins

[segiddins]

Can you please attach a full script that reproduces the issue? Thanks!

[EzimetYusup]

hey @segiddins,
I just attached sample to reproduce the issue, open the project then run the 'run_all_script' target, the group which has duplicated file_reference is 'generated_model_src'
XcodePorjectTest.zip
thanks!

[EzimetYusup]

hey @segiddins @fabiopelosin ,
I think the problem is because the both files are having same hash, I tried to print file_reference.to_hash method, although both duplicated file has different uuid, they do have same to_hash, I also look into source code and found that remove_reference is going to remove all the file_reference which has same hash, with comparing by == operation. is there any reason uuid is not included in to_hash method? or am I missing something else.
thanks!

[EzimetYusup]

hey @segiddins ,
this solved my problem, I just changed object.rb from

def ==(other)
          other.is_a?(AbstractObject) && to_hash == other.to_hash
end

to this

def ==(other)
          other.is_a?(AbstractObject) && to_hash == other.to_hash && uuid == other.uuid
end

could you take a look?
thanks!

[segiddins]

Want to make a PR with that change and a test? It seems reasonable to me!

[EzimetYusup]

@segiddins
would love to do that, but I am not sure how to do the test part? any suggestion for test?

[segiddins]

Make two objects with the same properties, assign different UUIDs, assert they're not equal