Skip to content

Commit bf1f5be

Browse files
authored
Merge pull request #14 from Code-Hex/fix/issues
fixed some issues for cookie
2 parents 26faba9 + 4260453 commit bf1f5be

File tree

6 files changed

+27
-3
lines changed

6 files changed

+27
-3
lines changed

.vscode/settings.json

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"deno.codeLens.references": true,
3+
"deno.enablePaths": [
4+
"./scripts"
5+
],
6+
"deno.enable": true
7+
}

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"scripts": {
1616
"test": "vitest run",
1717
"test-with-emulator": "firebase emulators:exec --project project12345 'vitest run'",
18-
"build": "run-p build:*",
18+
"build": "deno run --allow-read --allow-write scripts/version.ts && run-p build:*",
1919
"build:main": "tsc -p tsconfig.main.json",
2020
"build:module": "tsc -p tsconfig.module.json",
2121
"start-firebase-emulator": "firebase emulators:start --project project12345",

scripts/version.ts

+16
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
const decoder = new TextDecoder('utf-8');
2+
const encoder = new TextEncoder();
3+
4+
async function updateVersion() {
5+
const packageJsonText = decoder.decode(await Deno.readFile('./package.json'));
6+
const packageJson = JSON.parse(packageJsonText);
7+
const version = packageJson.version;
8+
9+
const versionTsContent = `export const version = '${version}';\n`;
10+
await Deno.writeFile('src/version.ts', encoder.encode(versionTsContent));
11+
}
12+
13+
updateVersion().catch(error => {
14+
console.error('failed to update version.ts:', error);
15+
Deno.exit(1);
16+
});

src/client.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import { version } from '../package.json';
21
import type { ApiSettings } from './api-requests';
32
import type { Credential } from './credential';
43
import { useEmulator, type EmulatorEnv } from './emulator';
54
import { AppErrorCodes, FirebaseAppError } from './errors';
5+
import { version } from './version';
66

77
/**
88
* Specifies how failing HTTP requests should be retried.

src/jwk-fetcher.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export class UrlKeyFetcher implements KeyFetcher {
6363

6464
// store the public keys cache in the KV store.
6565
const maxAge = parseMaxAge(cacheControlHeader);
66-
if (!isNaN(maxAge)) {
66+
if (!isNaN(maxAge) && maxAge > 0) {
6767
await this.keyStorer.put(JSON.stringify(publicKeys.keys), maxAge);
6868
}
6969

src/version.ts

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export const version = '1.2.0';

0 commit comments

Comments
 (0)