Skip to content

Commit b214734

Browse files
authored
[CI] Build NCHWc code on Windows/Linux ARM64 CIs (microsoft#27273)
### Description Initially the NCHWc code was built only on Mac CIs to keep the build path regression-free. There were some Linux-specific paths introduced in microsoft#26838 and there is more community interest in contributing to these code paths. See microsoft#27099. Hence, it makes sense to keep these code paths built and tested on Linux and Windows too. ### Motivation and Context Improve CI quality with regards to ARM64 NCHWc builds CC: @Rohanjames1997
1 parent 40d36b1 commit b214734

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

.github/workflows/linux_ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ jobs:
9494
dockerfile_path: tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/Dockerfile
9595
docker_image_repo: onnxruntimecpubuildciaarch64
9696
# ASan disabled due to excessive runtime (>4hr). Includes wheel build for basic checks.
97-
extra_build_flags: '--use_binskim_compliant_compile_flags --build_shared_lib'
97+
extra_build_flags: '--use_binskim_compliant_compile_flags --build_shared_lib --enable_arm_neon_nchwc'
9898
job_identifier: build-linux-arm64-debug
9999
secrets:
100100
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

tools/ci_build/github/azure-pipelines/win-qnn-arm64-ci-pipeline.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,11 @@ jobs:
5353
matrix:
5454
SHARED_LIB:
5555
QnnLibKind: 'shared_lib'
56-
ExtraQnnBuildArgs: '--client_package_build'
56+
# We currently do not have a standalone Windows ARM64 CI pipeline for the CPU EP,
57+
# so we enable --enable_arm_neon_nchwc for additional coverage of the NCHWc code paths in the CPU EP.
58+
# Once we have a standalone Windows ARM64 CI pipeline for the CPU EP, we can consider adding --enable_arm_neon_nchwc
59+
# to that pipeline and removing it from this pipeline since this pipeline is primarily for testing the QNN EP.
60+
ExtraQnnBuildArgs: '--client_package_build --enable_arm_neon_nchwc'
5761
STATIC_LIB:
5862
QnnLibKind: 'static_lib'
5963
ExtraQnnBuildArgs: ''

0 commit comments

Comments
 (0)