Fix code review feedback: standardize toast, add clipboard safety, remove unused vars

Co-authored-by: syed-reza98 <71028588+syed-reza98@users.noreply.github.com>

Author: Copilot

src/app/api/admin/activity/route.ts

@@ -25,9 +25,9 @@ export async function GET(request: NextRequest) {
     const { searchParams } = new URL(request.url);
     const page = parseInt(searchParams.get('page') || '1');
     const limit = parseInt(searchParams.get('limit') || '50');
-    const userId = searchParams.get('userId') || '';
-    const action = searchParams.get('action') || '';
-    const resource = searchParams.get('resource') || '';
+    // const userId = searchParams.get('userId') || '';
+    // const action = searchParams.get('action') || '';
+    // const resource = searchParams.get('resource') || '';
 
     // Mock activity logs - In production, fetch from database/log system
     const activities = Array.from({ length: limit }, (_, i) => {

src/app/api/admin/users/route.ts

@@ -30,9 +30,9 @@ export async function GET(request: NextRequest) {
     const { searchParams } = new URL(request.url);
     const page = parseInt(searchParams.get('page') || '1');
     const limit = parseInt(searchParams.get('limit') || '20');
-    const search = searchParams.get('search') || '';
-    const role = searchParams.get('role') || '';
-    const status = searchParams.get('status') || '';
+    // const search = searchParams.get('search') || '';
+    // const role = searchParams.get('role') || '';
+    // const status = searchParams.get('status') || '';
 
     // Mock users data - In production, fetch from database
     const users = Array.from({ length: limit }, (_, i) => ({

src/app/checkout/page.tsx

@@ -45,7 +45,7 @@ export default function CheckoutPage() {
   const router = useRouter();
   const [currentStep, setCurrentStep] = useState(0);
   const [shippingAddress, setShippingAddress] = useState<ShippingAddress | null>(null);
-  const [paymentMethodId, setPaymentMethodId] = useState<string | null>(null);
+  // const [paymentMethodId, setPaymentMethodId] = useState<string | null>(null);
   const [isProcessing, setIsProcessing] = useState(false);
 
   const steps: CheckoutStep[] = [

src/components/cart/cart-list.tsx

@@ -13,7 +13,7 @@ import {
 import { Badge } from '@/components/ui/badge';
 import { Input } from '@/components/ui/input';
 import { Minus, Plus, Trash2, ShoppingCart, ArrowRight } from 'lucide-react';
-import { useToast } from '@/hooks/use-toast';
+import { toast } from 'sonner';
 import { useRouter } from 'next/navigation';
 
 interface CartItem {
@@ -67,7 +67,6 @@ export function CartList() {
   const [cart, setCart] = useState<Cart | null>(null);
   const [loading, setLoading] = useState(true);
   const [updatingItems, setUpdatingItems] = useState<Set<string>>(new Set());
-  const { toast } = useToast();
   const router = useRouter();
 
   useEffect(() => {
@@ -121,15 +120,9 @@ export function CartList() {
         };
       });
 
-      toast({
-        title: 'Cart updated',
-        description: 'Item quantity updated successfully',
-      });
+      toast.success('Item quantity updated successfully');
     } catch {
-      toast({
-        title: 'Update failed',
-        description: 'Failed to update item quantity',
-      });
+      toast.error('Failed to update item quantity');
     } finally {
       setUpdatingItems(prev => {
         const next = new Set(prev);
@@ -158,15 +151,9 @@ export function CartList() {
         };
       });
 
-      toast({
-        title: 'Item removed',
-        description: 'Item removed from cart',
-      });
+      toast.success('Item removed from cart');
     } catch {
-      toast({
-        title: 'Remove failed',
-        description: 'Failed to remove item from cart',
-      });
+      toast.error('Failed to remove item from cart');
     } finally {
       setUpdatingItems(prev => {
         const next = new Set(prev);
@@ -188,15 +175,9 @@ export function CartList() {
 
       setCart({ ...mockCart, items: [], itemCount: 0, subtotal: 0, total: 0 });
 
-      toast({
-        title: 'Cart cleared',
-        description: 'All items removed from cart',
-      });
+      toast.success('All items removed from cart');
     } catch {
-      toast({
-        title: 'Clear failed',
-        description: 'Failed to clear cart',
-      });
+      toast.error('Failed to clear cart');
     }
   };
 

src/components/coupons/coupons-list.tsx

@@ -25,7 +25,7 @@ import {
   DropdownMenuTrigger,
 } from '@/components/ui/dropdown-menu';
 import { Plus, MoreHorizontal, Copy, Edit, Trash2, Percent, DollarSign } from 'lucide-react';
-import { useToast } from '@/hooks/use-toast';
+import { toast } from 'sonner';
 import { CreateCouponDialog } from './create-coupon-dialog';
 
 interface Coupon {
@@ -87,7 +87,6 @@ export function CouponsList() {
   const [coupons, setCoupons] = useState<Coupon[]>([]);
   const [loading, setLoading] = useState(true);
   const [isCreateOpen, setIsCreateOpen] = useState(false);
-  const { toast } = useToast();
 
   useEffect(() => {
     const fetchCoupons = async () => {
@@ -111,20 +110,18 @@ export function CouponsList() {
   }, []);
 
   const handleCopyCode = (code: string) => {
-    navigator.clipboard.writeText(code);
-    toast({
-      title: 'Code copied',
-      description: `Coupon code "${code}" copied to clipboard`,
-    });
+    if (navigator.clipboard && navigator.clipboard.writeText) {
+      navigator.clipboard.writeText(code);
+      toast.success(`Coupon code "${code}" copied to clipboard`);
+    } else {
+      toast.error('Clipboard not available');
+    }
   };
 
   const handleDelete = async (couponId: string) => {
     if (!confirm('Are you sure you want to delete this coupon?')) return;
 
-    toast({
-      title: 'Coupon deleted',
-      description: 'The coupon has been removed',
-    });
+    toast.success('The coupon has been removed');
 
     setCoupons(prev => prev.filter(c => c.id !== couponId));
   };

src/components/emails/edit-email-template-dialog.tsx

@@ -20,7 +20,7 @@ import {
   SelectTrigger,
   SelectValue,
 } from '@/components/ui/select';
-import { useToast } from '@/hooks/use-toast';
+import { toast } from 'sonner';
 
 interface EmailTemplate {
   id: string;
@@ -69,7 +69,6 @@ export function EditEmailTemplateDialog({
   </div>
 </body>
 </html>`);
-  const { toast } = useToast();
   const [isSaving, setIsSaving] = useState(false);
 
   const handleSave = async () => {
@@ -78,10 +77,7 @@ export function EditEmailTemplateDialog({
     // Simulate API call
     await new Promise(resolve => setTimeout(resolve, 500));
 
-    toast({
-      title: 'Template updated',
-      description: `"${name}" has been updated successfully.`,
-    });
+    toast.success(`"${name}" has been updated successfully.`);
 
     setIsSaving(false);
     onOpenChange(false);

src/components/emails/email-templates-list.tsx

@@ -19,7 +19,7 @@ import {
 import { MoreHorizontal, Mail, Edit, Eye, Send } from 'lucide-react';
 import { EditEmailTemplateDialog } from './edit-email-template-dialog';
 import { PreviewEmailDialog } from './preview-email-dialog';
-import { useToast } from '@/hooks/use-toast';
+import { toast } from 'sonner';
 
 interface EmailTemplate {
   id: string;
@@ -83,21 +83,14 @@ export function EmailTemplatesList() {
   const [templates] = useState<EmailTemplate[]>(mockTemplates);
   const [editingTemplate, setEditingTemplate] = useState<EmailTemplate | null>(null);
   const [previewTemplate, setPreviewTemplate] = useState<EmailTemplate | null>(null);
-  const { toast } = useToast();
 
   const handleSendTest = (template: EmailTemplate) => {
-    toast({
-      title: 'Test email sent',
-      description: `Test email for "${template.name}" sent to your email address.`,
-    });
+    toast.success(`Test email for "${template.name}" sent to your email address.`);
   };
 
   const handleToggleActive = (template: EmailTemplate) => {
     const newStatus = !template.active;
-    toast({
-      title: newStatus ? 'Template activated' : 'Template deactivated',
-      description: `"${template.name}" is now ${newStatus ? 'active' : 'inactive'}.`,
-    });
+    toast.success(`"${template.name}" is now ${newStatus ? 'active' : 'inactive'}.`);
   };
 
   return (

src/components/integrations/integrations-list.tsx

@@ -11,7 +11,7 @@
 import { useState, useEffect } from 'react';
 import { MoreHorizontal, CheckCircle, Settings } from 'lucide-react';
 import { Button } from '@/components/ui/button';
-import { Card, CardContent, CardDescription, CardFooter, CardHeader, CardTitle } from '@/components/ui/card';
+import { Card, CardContent, CardFooter, CardHeader, CardTitle } from '@/components/ui/card';
 import {
   DropdownMenu,
   DropdownMenuContent,

src/components/inventory/inventory-page-client.tsx

@@ -68,7 +68,7 @@ export function InventoryPageClient() {
   const [loading, setLoading] = useState(true);
   const [search, setSearch] = useState('');
   const [lowStockOnly, setLowStockOnly] = useState(false);
-  const [selectedStore, setSelectedStore] = useState<string>('');
+  const [selectedStore] = useState<string>(''); // setSelectedStore removed - not yet implemented
   const [adjustDialogOpen, setAdjustDialogOpen] = useState(false);
   const [selectedItem, setSelectedItem] = useState<InventoryItem | null>(null);
   const [adjustmentType, setAdjustmentType] = useState<'ADD' | 'REMOVE' | 'SET'>('ADD');

src/components/notifications/notifications-list.tsx

@@ -12,7 +12,7 @@ import {
 import { Badge } from '@/components/ui/badge';
 import { Tabs, TabsContent, TabsList, TabsTrigger } from '@/components/ui/tabs';
 import { Bell, Package, ShoppingCart, Users, AlertCircle, CheckCircle, XCircle } from 'lucide-react';
-import { useToast } from '@/hooks/use-toast';
+import { toast } from 'sonner';
 
 interface Notification {
   id: string;
@@ -107,34 +107,24 @@ const getPriorityColor = (priority: string) => {
 
 export function NotificationsList() {
   const [notifications, setNotifications] = useState<Notification[]>(mockNotifications);
-  const { toast } = useToast();
 
   const unreadCount = notifications.filter((n) => !n.read).length;
 
   const handleMarkAsRead = (id: string) => {
     setNotifications((prev) =>
       prev.map((n) => (n.id === id ? { ...n, read: true } : n))
     );
-    toast({
-      title: 'Marked as read',
-      description: 'Notification marked as read.',
-    });
+    toast.success('Notification marked as read.');
   };
 
   const handleMarkAllAsRead = () => {
     setNotifications((prev) => prev.map((n) => ({ ...n, read: true })));
-    toast({
-      title: 'All notifications read',
-      description: 'All notifications have been marked as read.',
-    });
+    toast.success('All notifications have been marked as read.');
   };
 
   const handleClearAll = () => {
     setNotifications([]);
-    toast({
-      title: 'Notifications cleared',
-      description: 'All notifications have been removed.',
-    });
+    toast.success('All notifications have been removed.');
   };
 
   const getRelativeTime = (dateString: string) => {