Eliminate statSync calls and filter prefixes first in path completion

Author: nordicnode

cli/src/__tests__/path-completion.test.ts

@@ -1,4 +1,10 @@
-import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'fs'
+import {
+  mkdirSync,
+  mkdtempSync,
+  rmSync,
+  symlinkSync,
+  writeFileSync,
+} from 'fs'
 import os from 'os'
 import path from 'path'
 
@@ -239,5 +245,17 @@ describe('getPathCompletion', () => {
       // Files should be ignored, common prefix from directories only
       expect(result).toBe(path.join(tempDir, 'project-'))
     })
+
+    test('completes symlinks pointing to directories', () => {
+      const targetDir = path.join(tempDir, 'actual-dir')
+      mkdirSync(targetDir)
+      try {
+        symlinkSync(targetDir, path.join(tempDir, 'symlinked-dir'))
+        const result = getPathCompletion(path.join(tempDir, 'sym'))
+        expect(result).toBe(path.join(tempDir, 'symlinked-dir') + path.sep)
+      } catch {
+        // Skip on systems where symlink creation is unprivileged/unsupported
+      }
+    })
   })
 })

cli/src/utils/path-completion.ts

@@ -48,22 +48,29 @@ export function getPathCompletion(inputPath: string): string | null {
 
   // List directories in parent that match the partial
   try {
-    const items = readdirSync(parentDir)
+    const entries = readdirSync(parentDir, { withFileTypes: true })
     const matches: string[] = []
 
-    for (const item of items) {
+    for (const entry of entries) {
+      const name = entry.name
       // Skip hidden files unless user typed a dot
-      if (item.startsWith('.') && !partial.startsWith('.')) continue
+      if (name.startsWith('.') && !partial.startsWith('.')) continue
 
-      const fullPath = path.join(parentDir, item)
-      try {
-        if (!statSync(fullPath).isDirectory()) continue
-      } catch {
-        continue
+      // Filter by prefix first before doing any directory resolution
+      if (!name.toLowerCase().startsWith(partial)) continue
+
+      let isDirectory = entry.isDirectory()
+      if (!isDirectory && entry.isSymbolicLink()) {
+        try {
+          const fullPath = path.join(parentDir, name)
+          isDirectory = statSync(fullPath).isDirectory()
+        } catch {
+          isDirectory = false
+        }
       }
 
-      if (item.toLowerCase().startsWith(partial)) {
-        matches.push(item)
+      if (isDirectory) {
+        matches.push(name)
       }
     }