We're re-querying unnecessarily
To see it, search for a school (e.g. Darlinghurst Public) and clear your console. No nearby schools are shown.
Click to expand the nearby schools control. You'll see a query in the console. That's fine, since it's checking the 'show nearby schools' checkbox for you.
Click to collapse the nearby schools control. This shouldn't do reload the nearby schools since they've already been loaded and the user hasn't un-checked the 'show nearby schools' checkbox, but you will notice a new SELECT query in the console.
In addition to running queries when we don't need to, the map unloads and loads the set of nearby schools, so you notice them flicker on the map.
We're re-querying unnecessarily
To see it, search for a school (e.g. Darlinghurst Public) and clear your console. No nearby schools are shown.
Click to expand the nearby schools control. You'll see a query in the console. That's fine, since it's checking the 'show nearby schools' checkbox for you.
Click to collapse the nearby schools control. This shouldn't do reload the nearby schools since they've already been loaded and the user hasn't un-checked the 'show nearby schools' checkbox, but you will notice a new SELECT query in the console.
In addition to running queries when we don't need to, the map unloads and loads the set of nearby schools, so you notice them flicker on the map.