add recursive option to Character.getList, to include ones in folders for input text suggestions and to fix the character editor command not working with folders

Author: TheZoroForce240

assets/data/editors/layouts/stage/characterEditScreen.xml

@@ -95,7 +95,7 @@
 			import funkin.game.Character;
 
 			var curCharBox = new UIAutoCompleteTextBox(col(2), charTypeY, char.curCharacter, 145, 32);
-			curCharBox.suggestItems = Character.getList(false);
+			curCharBox.suggestItems = Character.getList(false, false, null, true);
 			self.add(curCharBox);
 		 </exec>
 	</section>

source/funkin/backend/system/console/BuiltInCommands.hx

@@ -152,7 +152,7 @@ class BuiltInCommands {
 			return;
 		}
 		var name:String = args[0];
-		var list = Character.getList(false, true);
+		var list = Character.getList(false, false, null, true);
 		if (!list.contains(name)) {
 			Logs.error('Character $name was not found.');
 			return;

source/funkin/editors/charter/ChartCreationScreen.hx

@@ -39,8 +39,8 @@ class ChartCreationScreen extends UISubstateWindow {
 			return text;
 		}
 
-		charFileList = Character.getList(true);
-		if (charFileList.length == 0) charFileList = Character.getList(false);
+		charFileList = Character.getList(true, false, null, true);
+		if (charFileList.length == 0) charFileList = Character.getList(false, false, null, true);
 
 		var chartTitle:UIText;
 		add(chartTitle = new UIText(windowSpr.x + 20, windowSpr.y + 30 + 16, 0, TU.translate("chartCreation.info"), 28));

source/funkin/editors/charter/CharterEventScreen.hx

@@ -185,7 +185,7 @@ class CharterEventScreen extends UISubstateWindow {
 						dropdown;
 					case TCharacter:
 						addLabel();
-						var charFileList = Character.getList(false);
+						var charFileList = Character.getList(false, false, null, true);
 						var textBox:UIAutoCompleteTextBox = new UIAutoCompleteTextBox(eventName.x, y, cast value);
 						textBox.suggestItems = charFileList;
 						paramsPanel.add(textBox); paramsFields.push(textBox);

source/funkin/editors/charter/CharterEventScreenNew.hx

@@ -177,7 +177,7 @@ class CharterEventScreenNew extends MusicBeatSubstate {
 						dropdown;
 					case TCharacter:
 						addLabel();
-						var charFileList = Character.getList(false);
+						var charFileList = Character.getList(false, false, null, true);
 						var textBox:UIAutoCompleteTextBox = new UIAutoCompleteTextBox(eventName.x+6, winHeight, cast value);
 						textBox.suggestItems = charFileList;
 						paramsPanel.add(textBox); paramsFields.push(textBox);

source/funkin/editors/charter/CharterStrumlineScreen.hx

@@ -73,8 +73,8 @@ class CharterStrumlineScreen extends UISubstateWindow {
 		var title:UIText;
 		add(title = new UIText(windowSpr.x + 20, windowSpr.y + 30 + 16, 0, TU.translate("charterStrumlineScreen.title" + (creatingStrumLine ? "-creating" : "-editing")), 28));
 
-		var charFileList = Character.getList(true);
-		if (charFileList.length == 0) charFileList = Character.getList(false);
+		var charFileList = Character.getList(true, false, null, true);
+		if (charFileList.length == 0) charFileList = Character.getList(false, false, null, true);
 
 		charactersList = new UIButtonList<CharacterButton>(15, title.y + title.height + 36, 250, 269, null, FlxPoint.get(250, 54), null, 0);
 		charactersList.addButton.callback = () -> charactersList.add(new CharacterButton(0, 0, TU.translate("charterStrumLine.newChar"), charFileList, charactersList));

source/funkin/game/Character.hx

@@ -624,17 +624,30 @@ class Character extends FunkinSprite implements IBeatReceiver implements IOffset
 		return icon;
 	}
 
-	public static function getList(?mods:Bool = false, includeFolders:Bool = false, folder:String = 'data/characters/'):Array<String> {
+	public static function getList(?mods:Bool = false, includeFolders:Bool = false, ?folder:String = null, ?recursive:Bool = false):Array<String> {
+		final defaultFolder:String = 'data/characters/';
+		if (folder == null) folder = defaultFolder;
 		var list:Array<String> = [];
-		if(includeFolders) {
+		if(includeFolders || recursive) {
 			for (path in Paths.getFolderDirectories(folder, true, mods ? MODS : BOTH)) {
 				if(!path.endsWith("/")) path += "/";
-				list.push(path);
+				if (recursive) {
+					list = list.concat(Character.getList(mods, includeFolders, path, recursive));
+				} else {
+					list.push(path);
+				}
 			}
 		}
 		for (path in Paths.getFolderContent(folder, true, mods ? MODS : BOTH))
-			if (Path.extension(path) == "xml")
-				list.push(CoolUtil.getFilename(path));
+			if (Path.extension(path) == "xml") {
+				if (recursive) {
+					var file:String = folder + CoolUtil.getFilename(path);
+					if (file.startsWith(defaultFolder)) file = file.substr(defaultFolder.length);
+					list.push(file);
+				} else {
+					list.push(CoolUtil.getFilename(path));
+				}
+			}
 		return list;
 	}
 }