Skip to content

Commit c8538a7

Browse files
authored
Merge pull request #75 from CodinGame/update-monaco-0.36
Update to monaco 0.36
2 parents daccb02 + 6f10429 commit c8538a7

32 files changed

Lines changed: 515 additions & 311 deletions

README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,13 @@ Usage:
6868
```typescript
6969
import { StandaloneServices } from 'vscode/services'
7070
import getModelEditorServiceOverride from 'vscode/service-override/modelEditor'
71-
import getMessageServiceOverride from 'vscode/service-override/messages'
7271
import getConfigurationServiceOverride, { updateUserConfiguration, configurationRegistry } from 'vscode/service-override/configuration'
7372

7473
StandaloneServices.initialize({
7574
...getModelEditorServiceOverride((model, input, sideBySide) => {
7675
// Open a new editor here and return it
7776
// It will be called when for instance the user ctrl+click on an import
7877
}),
79-
...getMessageServiceOverride(document.body),
8078
...getConfigurationServiceOverride()
8179
})
8280

@@ -167,7 +165,7 @@ From CLI run:
167165
```bash
168166
cd demo
169167
npm ci
170-
npm run start
168+
npm start
171169
# OR: for vite debug output
172170
npm run start:debug
173171
```

demo/package-lock.json

Lines changed: 14 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo/package.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,18 @@
66
"scripts": {
77
"clean": "tsc -b -c",
88
"compile": "tsc",
9-
"start": "vite",
10-
"start:debug": "vite --debug --force"
9+
"start": "vite --config vite.config.ts",
10+
"start:debug": "vite --config vite.config.ts --debug --force"
1111
},
1212
"devDependencies": {
1313
"@types/throttle-debounce": "~5.0.0",
1414
"typescript": "~4.9.5",
1515
"vite": "~4.1.4"
1616
},
1717
"dependencies": {
18-
"monaco-editor": "~0.34.1",
1918
"throttle-debounce": "~5.0.0",
2019
"vscode": "file:../",
21-
"vscode-oniguruma": "~1.6.2"
20+
"vscode-oniguruma": "~1.7.0"
2221
},
2322
"volta": {
2423
"node": "18.14.2",

demo/src/main.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@ import { createConfiguredEditor, getJsonSchemas, onDidChangeJsonSchema } from 'v
1717
import { debounce } from 'throttle-debounce'
1818
import * as vscode from 'vscode'
1919

20+
monaco.languages.json.jsonDefaults.setModeConfiguration({
21+
...monaco.languages.json.jsonDefaults.modeConfiguration,
22+
tokens: false // Disable monarch tokenizer as we use TextMate here
23+
})
24+
2025
void vscode.window.showInformationMessage('Hello', {
2126
detail: 'Welcome to the monaco-vscode-api demo',
2227
modal: true

demo/src/setup.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ import JsonWorker from 'monaco-editor/esm/vs/language/json/json.worker?worker'
2323
import themes from './resources/themes/themes.json'
2424

2525
// Workers
26-
interface WrappedWorker {
26+
interface WorkerConstructor {
2727
new(): Worker
2828
}
29-
export type WorkerLoader = () => WrappedWorker | Promise<WrappedWorker>
29+
export type WorkerLoader = () => WorkerConstructor | Promise<WorkerConstructor>
3030
const workerLoaders: Partial<Record<string, WorkerLoader>> = {
3131
editorWorkerService: () => EditorWorker,
3232
json: () => JsonWorker
@@ -63,14 +63,14 @@ StandaloneServices.initialize({
6363
...getLanguagesServiceOverride()
6464
})
6565

66-
const loader = {
66+
const loader: Partial<Record<string, () => Promise<string>>> = {
6767
'/themes/dark_plus.json': async () => (await import('./resources/themes/theme-defaults~dark_plus.json?raw')).default,
6868
'/themes/light_plus.json': async () => (await import('./resources/themes/theme-defaults~light_plus.json?raw')).default,
6969
'/themes/dark_vs.json': async () => (await import('./resources/themes/theme-defaults~dark_vs.json?raw')).default,
7070
'/themes/light_vs.json': async () => (await import('./resources/themes/theme-defaults~light_vs.json?raw')).default,
7171
'/themes/hc_black.json': async () => (await import('./resources/themes/theme-defaults~hc_black.json?raw')).default,
7272
'/themes/hc_light.json': async () => (await import('./resources/themes/theme-defaults~hc_light.json?raw')).default
73-
} as Partial<Record<string, () => Promise<string>>>
73+
}
7474
setDefaultThemes(themes as IThemeExtensionPoint[], async (theme) => loader[theme.path.slice(1)]!())
7575

7676
setLanguages([{

demo/src/types.d.ts

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
declare module '*?url' {
2+
const url: string
3+
export default url
4+
}
5+
6+
declare module '*?worker' {
7+
interface WorkerConstructor {
8+
new(): Worker
9+
}
10+
11+
const Worker: WorkerConstructor
12+
export default Worker
13+
}
14+
15+
declare module '*?raw' {
16+
const content: string
17+
export default content
18+
}

demo/vite.config.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
import { defineConfig } from 'vite'
2+
3+
export default defineConfig({
4+
server: {
5+
fs: {
6+
allow: ['../'] // allow to load codicon.tss from monaco-editor in the parent folder
7+
}
8+
}
9+
})

0 commit comments

Comments
 (0)