Skip to content

Commit e341efd

Browse files
author
Loïc Mangeonjean
committed
fix: missing service override
1 parent 6a9e52e commit e341efd

2 files changed

Lines changed: 22 additions & 2 deletions

File tree

src/missing-services.ts

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,8 +226,8 @@ import {
226226
import { IMultiDiffSourceResolverService } from 'vs/workbench/contrib/multiDiffEditor/browser/multiDiffSourceResolverService.service'
227227
import { INotebookOriginalCellModelFactory } from 'vs/workbench/contrib/notebook/browser/diff/inlineDiff/notebookOriginalCellModelFactory.service'
228228
import { INotebookOriginalModelReferenceFactory } from 'vs/workbench/contrib/notebook/browser/diff/inlineDiff/notebookOriginalModelRefFactory.service'
229-
import { INotebookCellOutlineDataSourceFactory } from 'vs/workbench/contrib/notebook/browser/viewModel/notebookOutlineDataSourceFactory.service'
230229
import { INotebookEditorService } from 'vs/workbench/contrib/notebook/browser/services/notebookEditorService.service'
230+
import { INotebookCellOutlineDataSourceFactory } from 'vs/workbench/contrib/notebook/browser/viewModel/notebookOutlineDataSourceFactory.service'
231231
import { INotebookCellStatusBarService } from 'vs/workbench/contrib/notebook/common/notebookCellStatusBarService.service'
232232
import { INotebookEditorModelResolverService } from 'vs/workbench/contrib/notebook/common/notebookEditorModelResolverService.service'
233233
import { INotebookExecutionService } from 'vs/workbench/contrib/notebook/common/notebookExecutionService.service'
@@ -423,6 +423,7 @@ import { IChatLayoutService } from 'vs/workbench/contrib/chat/common/chatLayoutS
423423
import { IChatModeService } from 'vs/workbench/contrib/chat/common/chatModes.service'
424424
import { IAiEditTelemetryService } from 'vs/workbench/contrib/editTelemetry/browser/telemetry/aiEditTelemetry/aiEditTelemetryService.service'
425425
import { LazyCollectionState } from 'vs/workbench/contrib/mcp/common/mcpTypes'
426+
import { INotebookOutlineEntryFactory } from 'vs/workbench/contrib/notebook/browser/viewModel/notebookOutlineEntryFactory.service'
426427
import { ChatEntitlement } from 'vs/workbench/services/chat/common/chatEntitlementService'
427428
import type { IInlineCompletionsUnificationState } from 'vs/workbench/services/inlineCompletions/common/inlineCompletionsUnification'
428429
import { IInlineCompletionsUnificationService } from 'vs/workbench/services/inlineCompletions/common/inlineCompletionsUnification.service'
@@ -5293,6 +5294,19 @@ registerSingleton(
52935294
NotebookCellOutlineDataSourceFactory,
52945295
InstantiationType.Delayed
52955296
)
5297+
5298+
class NotebookOutlineEntryFactory implements INotebookOutlineEntryFactory {
5299+
_serviceBrand: undefined
5300+
getOutlineEntries = () => []
5301+
@Unsupported
5302+
cacheSymbols: INotebookOutlineEntryFactory['cacheSymbols'] = unsupported
5303+
}
5304+
registerSingleton(
5305+
INotebookOutlineEntryFactory,
5306+
NotebookOutlineEntryFactory,
5307+
InstantiationType.Delayed
5308+
)
5309+
52965310
class QuickDiffModelService implements IQuickDiffModelService {
52975311
_serviceBrand: undefined
52985312
createQuickDiffModelReference: IQuickDiffModelService['createQuickDiffModelReference'] = () =>

src/service-override/notebook.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ import { NotebookOriginalModelReferenceFactory } from 'vs/workbench/contrib/note
3737
import { INotebookCellOutlineDataSourceFactory } from 'vs/workbench/contrib/notebook/browser/viewModel/notebookOutlineDataSourceFactory.service'
3838
import { NotebookCellOutlineDataSourceFactory } from 'vs/workbench/contrib/notebook/browser/viewModel/notebookOutlineDataSourceFactory'
3939
import 'vs/workbench/contrib/notebook/browser/notebook.contribution'
40+
import { NotebookOutlineEntryFactory } from 'vs/workbench/contrib/notebook/browser/viewModel/notebookOutlineEntryFactory'
41+
import { INotebookOutlineEntryFactory } from 'vs/workbench/contrib/notebook/browser/viewModel/notebookOutlineEntryFactory.service'
4042

4143
export default function getServiceOverride(): IEditorOverrideServices {
4244
return {
@@ -97,7 +99,11 @@ export default function getServiceOverride(): IEditorOverrideServices {
9799
[],
98100
true
99101
),
100-
102+
[INotebookOutlineEntryFactory.toString()]: new SyncDescriptor(
103+
NotebookOutlineEntryFactory,
104+
[],
105+
true
106+
)
101107

102108
}
103109
}

0 commit comments

Comments
 (0)