Merge pull request #92 from CodinGame/fix-missing-color

Fix missing colors

Author: CGNonofr

README.md

@@ -8,7 +8,7 @@ The VSCode api is composed of:
 - Some features that are supported by Monaco (Language feature registrations...) which are just forwarded to it (with some transformations)
 - Some features that are not supported by Monaco, and in such case:
   - If it's an important feature: we let the user implement it as they wish.
-  - If it's some advanced features that don't make a lot of sense on Monaco (debug, tests...), it just throws an error when you try to use it.
+  - If it's some advanced features that don't make a lot of sense on Monaco (scm, tests...), it just throws an error when you try to use it.
 
 To implement by hands the optional features (file system, workspace folders, file...), you can use the `Services` namespace from `vscode/services`:
 
@@ -161,6 +161,7 @@ It includes:
 - Keybinding service, with user keybindings editor
 - Token classification
 - Snippets (but not working in monaco 0.34)
+- Debuggers
 
 It also uses the `getJsonSchemas` function to register them on the monaco json worker and have autocomplete/hover on settings and keybindings.
 
@@ -174,6 +175,11 @@ npm start
 npm run start:debug
 ```
 
+For the debug feature, also run:
+```bash
+npm run start:debugServer
+```
+
 ### History
 
 This project was mainly created to make the implementation of [monaco-languageclient](https://github.com/TypeFox/monaco-languageclient) more robust and maintainable.

demo/src/style.css

@@ -5,8 +5,6 @@
   font-weight: 400;
 
   color-scheme: light dark;
-  color: rgba(255, 255, 255, 0.87);
-  background-color: #242424;
 
   font-synthesis: none;
   text-rendering: optimizeLegibility;
@@ -15,6 +13,11 @@
   -webkit-text-size-adjust: 100%;
 }
 
+body {
+  background-color: var(--vscode-editorWidget-background);
+  color: var(--vscode-editorWidget-foreground);
+}
+
 .editor {
   width: 900px;
   height: 400px;

rollup/rollup.config.ts

@@ -58,7 +58,6 @@ const PURE_FUNCTIONS = new Set([
 
 // Function calls to remove when the result is not used
 const FUNCTIONS_TO_REMOVE = new Set([
-  'registerColor',
   'colorRegistry.onDidChangeSchema',
   'registerSingleton', // Remove calls to registerSingleton from vscode code, we just want to import things, not registering services
   'registerProxyConfigurations',
@@ -94,6 +93,12 @@ const REMOVE_COMMANDS = new Set([
   'debug.openBreakpointToSide'
 ])
 
+const KEEP_COLORS = new Set([
+  'notifications.background',
+  'notification.foreground',
+  'notificationToast.border'
+])
+
 function isCallPure (functionName: string, args: recast.types.namedTypes.CallExpression['arguments']): boolean {
   if (functionName === 'KeybindingsRegistry.registerCommandAndKeybindingRule') {
     const firstParam = args[0]!
@@ -122,6 +127,15 @@ function isCallPure (functionName: string, args: recast.types.namedTypes.CallExp
     }
   }
 
+  if (functionName.endsWith('registerColor')) {
+    const firstParam = args[0]!
+    if (firstParam.type === 'StringLiteral') {
+      if (KEEP_COLORS.has(firstParam.value)) {
+        return false
+      }
+    }
+  }
+
   return PURE_OR_TO_REMOVE_FUNCTIONS.has(functionName)
 }