refactor(win32): force CP_UTF8 to get rid of all wchar use

See https://learn.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page

Signed-off-by: Coelacanthus <uwu@coelacanthus.name>

Author: CoelacanthusHex

driver/apdu/at_win32.c

@@ -35,40 +35,35 @@ static void enumerate_com_ports(cJSON *data) {
     SP_DEVINFO_DATA devInfoData;
     DWORD i;
 
-    hDevInfo = SetupDiGetClassDevsW(&GUID_DEVCLASS_PORTS, 0, 0, DIGCF_PRESENT);
+    hDevInfo = SetupDiGetClassDevsA(&GUID_DEVCLASS_PORTS, 0, 0, DIGCF_PRESENT);
     if (hDevInfo == INVALID_HANDLE_VALUE)
         return;
 
     devInfoData.cbSize = sizeof(SP_DEVINFO_DATA);
     for (i = 0; SetupDiEnumDeviceInfo(hDevInfo, i, &devInfoData); i++) {
-        wchar_t portName[256] = {0};
-        wchar_t friendlyName[256] = {0};
-        char portNameMB[256] = {0};
-        char friendlyNameMB[256] = {0};
+        char portName[256] = {0};
+        char friendlyName[256] = {0};
         DWORD size = sizeof(portName);
 
         HKEY hKey = SetupDiOpenDevRegKey(hDevInfo, &devInfoData, DICS_FLAG_GLOBAL, 0, DIREG_DEV, KEY_READ);
         if (hKey != INVALID_HANDLE_VALUE) {
             DWORD type;
-            if (RegQueryValueExW(hKey, L"PortName", NULL, &type, (LPBYTE)portName, &size) != ERROR_SUCCESS
+            if (RegQueryValueExA(hKey, L"PortName", NULL, &type, (LPBYTE)portName, &size) != ERROR_SUCCESS
                 || type != REG_SZ) {
                 portName[0] = L'\0';
             }
         }
 
-        if (!SetupDiGetDeviceRegistryPropertyW(hDevInfo, &devInfoData, SPDRP_FRIENDLYNAME, NULL, (PBYTE)friendlyName,
+        if (!SetupDiGetDeviceRegistryPropertyA(hDevInfo, &devInfoData, SPDRP_FRIENDLYNAME, NULL, (PBYTE)friendlyName,
                                                sizeof(friendlyName), NULL)) {
             friendlyName[0] = L'\0';
         }
 
-        WideCharToMultiByte(CP_UTF8, 0, portName, -1, portNameMB, sizeof(portNameMB), NULL, NULL);
-        WideCharToMultiByte(CP_UTF8, 0, friendlyName, -1, friendlyNameMB, sizeof(friendlyNameMB), NULL, NULL);
-
-        if (starts_with(portNameMB, "COM")) {
+        if (starts_with(portName, "COM")) {
             cJSON *item = cJSON_CreateObject();
             if (item) {
-                cJSON_AddStringToObject(item, "env", portNameMB);
-                cJSON_AddStringToObject(item, "name", friendlyNameMB[0] ? friendlyNameMB : portNameMB);
+                cJSON_AddStringToObject(item, "env", portName);
+                cJSON_AddStringToObject(item, "name", friendlyName[0] ? friendlyName : portName);
                 cJSON_AddItemToArray(data, item);
             } else {
                 cJSON_Delete(item);
@@ -171,13 +166,10 @@ static int apdu_interface_connect(struct euicc_ctx *ctx) {
 
     logic_channel = 0;
 
-    char dev_ascii[64];
+    char devname[64];
     snprintf(dev_ascii, sizeof(dev_ascii), "\\\\.\\%s", device);
 
-    wchar_t devname[64];
-    mbstowcs(devname, dev_ascii, sizeof(devname) / sizeof(wchar_t));
-
-    hComm = CreateFileW(devname, GENERIC_READ | GENERIC_WRITE, 0, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL);
+    hComm = CreateFile(devname, GENERIC_READ | GENERIC_WRITE, 0, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL);
 
     if (hComm == INVALID_HANDLE_VALUE) {
         fprintf(stderr, "Failed to open device: %s, error: %lu\n", dev_ascii, GetLastError());

src/CMakeLists.txt

@@ -11,7 +11,7 @@ aux_source_directory(${CMAKE_CURRENT_SOURCE_DIR}/applet/chip DIR_LPAC_SRCS)
 aux_source_directory(${CMAKE_CURRENT_SOURCE_DIR}/applet/notification DIR_LPAC_SRCS)
 aux_source_directory(${CMAKE_CURRENT_SOURCE_DIR}/applet/profile DIR_LPAC_SRCS)
 
-add_executable(lpac ${DIR_LPAC_SRCS})
+add_executable(lpac ${DIR_LPAC_SRCS} lpac.manifest)
 target_link_libraries(lpac euicc-drivers lpac-utils)
 target_include_directories(lpac PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>)
 

src/lpac.manifest

@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
+<assembly manifestVersion="1.0" xmlns="urn:schemas-microsoft-com:asm.v1">
+  <assemblyIdentity type="win32" name="me.estk.lpac" version="6.0.0.0"/>
+  <application>
+    <windowsSettings>
+      <activeCodePage xmlns="http://schemas.microsoft.com/SMI/2019/WindowsSettings">UTF-8</activeCodePage>
+    </windowsSettings>
+  </application>
+</assembly>

src/main.c

@@ -126,28 +126,6 @@ void main_fini_euicc() {
     euicc_ctx_inited = 0;
 }
 
-#ifdef WIN32
-static char **warg_to_arg(const int wargc, wchar_t **wargv) {
-    char **argv = malloc(wargc * sizeof(char *));
-    if (argv == NULL) {
-        return NULL;
-    }
-    for (int i = 0; i < wargc; ++i) {
-        const int size = WideCharToMultiByte(CP_UTF8, 0, wargv[i], -1, NULL, 0, NULL, NULL);
-        argv[i] = malloc(size);
-        if (argv[i] == NULL) {
-            for (int j = 0; j < i; ++j) {
-                free(argv[j]);
-            }
-            free(argv);
-            return NULL;
-        }
-        WideCharToMultiByte(CP_UTF8, 0, wargv[i], -1, argv[i], size, NULL, NULL);
-    }
-    return argv;
-}
-#endif
-
 int main(int argc, char **argv) {
     int ret = 0;
 
@@ -167,7 +145,7 @@ int main(int argc, char **argv) {
     euicc_ctx.http.interface = &euicc_driver_interface_http;
 
 #ifdef WIN32
-    argv = warg_to_arg(argc, CommandLineToArgvW(GetCommandLineW(), &argc));
+    argv = CommandLineToArgvA(GetCommandLineA(), &argc);
     if (argv == NULL) {
         return -1;
     }