Skip to content

Commit 005c04f

Browse files
committed
audit(coderabbit): fix all of the bugs pointed out
1 parent da233a4 commit 005c04f

7 files changed

Lines changed: 26 additions & 9 deletions

File tree

api/handlers/transactions.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -502,6 +502,7 @@ func (h *TransactionsHandler) getMsgAuthCrSessionResponse(
502502
Creator: d.Creator,
503503
SessionKey: d.SessionKey,
504504
ExpiresAt: &expiresAt,
505+
AllowPaths: d.AllowPaths,
505506
SpendLimit: d.SpendLimit,
506507
SpendPeriod: &spendPeriod,
507508
}

api/huma-types/transaction.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ type TransactionMessage struct {
5656

5757
// Auth message specific fields
5858
SessionKey string `json:"session_key,omitempty" doc:"Session key hex (for auth_msg_create_session and auth_msg_revoke_session)"`
59+
AllowPaths []string `json:"allow_paths,omitempty" doc:"Allowed paths (only for auth_msg_create_session)"`
5960
ExpiresAt *time.Time `json:"expires_at,omitempty" doc:"Session expiry (only for auth_msg_create_session)"`
6061
SpendLimit []database.Amount `json:"spend_limit,omitempty" doc:"Spend limit (only for auth_msg_create_session)"`
6162
SpendPeriod *int64 `json:"spend_period,omitempty" doc:"Spend period in seconds; 0 means infinite (only for auth_msg_create_session)"`

cliff.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# Tuned to the existing CHANGELOG.md style (Keep a Changelog + Added/Changes/Fixed).
33
#
44
# Release workflow example:
5-
# 1. Preview: git cliff --unreleased --tag v.0.7.1
5+
# 1. Preview: git cliff --unreleased --tag v0.7.1
66
# 2. Prepend: git cliff --unreleased --tag v0.7.1 --prepend CHANGELOG.md
77
# 3. Edit the new section: add a release summary paragraph below the heading.
88
# 4. Commit: git add CHANGELOG.md && git commit -m "chore: release v0.7.1"

indexer/cli/setup.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -273,12 +273,6 @@ func createHypertables(dbInit *dbinit.DBInitializer, chainName string) error {
273273
OrderBy: "timestamp DESC",
274274
SegmentBy: []string{"chain_name", "message_counter"},
275275
}},
276-
{sdt.MsgMultiSend{}, dbinit.HypertableParams{
277-
PartitionColumn: "timestamp",
278-
ChunkInterval: "1 week",
279-
OrderBy: "timestamp DESC",
280-
SegmentBy: []string{"chain_name", "message_counter"},
281-
}},
282276
{sdt.TxHashId{}, dbinit.HypertableParams{
283277
PartitionColumn: "timestamp",
284278
ChunkInterval: "1 week",

indexer/decoder/convert.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,11 @@ func (c *converter) toMsgAddPackage() (*dataTypes.MsgAddPackage, error) {
228228
return nil, fmt.Errorf("missing send")
229229
}
230230

231+
pkgFileNames, ok := data["pkg_file_names"].([]string)
232+
if !ok {
233+
return nil, fmt.Errorf("missing pkg_file_names")
234+
}
235+
231236
send := make([]dataTypes.Amount, len(coinSend))
232237
for j, amt := range coinSend {
233238
bigInt := big.NewInt(amt.Amount)
@@ -260,6 +265,7 @@ func (c *converter) toMsgAddPackage() (*dataTypes.MsgAddPackage, error) {
260265
PkgPath: pkgPath,
261266
PkgName: pkgName,
262267
Send: send,
268+
PkgFileNames: pkgFileNames,
263269
MaxDeposit: maxDeposit,
264270
Signers: c.signerIds,
265271
Timestamp: c.timestamp,
@@ -319,13 +325,19 @@ func (c *converter) toMsgRun() (*dataTypes.MsgRun, error) {
319325
}
320326
}
321327

328+
pkgFileNames, ok := data["pkg_file_names"].([]string)
329+
if !ok {
330+
return nil, fmt.Errorf("missing pkg_file_names")
331+
}
332+
322333
return &dataTypes.MsgRun{
323334
TxId: c.txId,
324335
MessageCounter: messageCounter,
325336
ChainName: c.chainName,
326337
Caller: c.addressResolver.GetAddress(caller),
327338
PkgPath: pkgPath,
328339
PkgName: pkgName,
340+
PkgFileNames: pkgFileNames,
329341
Send: send,
330342
MaxDeposit: maxDeposit,
331343
Signers: c.signerIds,

indexer/decoder/process.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,11 +230,11 @@ func processAuthRv(
230230
messageCounter int16,
231231
) {
232232
creator := m.Creator.String()
233-
sessionKeyRaw := m.SessionKey.Bytes()
233+
sessionKey := m.SessionKey.Address().Bech32().String()
234234
messages[i] = map[string]any{
235235
"msg_type": "auth_msg_revoke_session",
236236
"creator": creator,
237-
"session_key_raw": sessionKeyRaw,
237+
"session_key": sessionKey,
238238
"message_counter": messageCounter,
239239
}
240240
}

pkgs/sql_data_types/hypertables.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -582,6 +582,9 @@ func (ma *MsgAuthCrSession) GetAllAddresses() *TxAddresses {
582582
txAddresses := NewTxAddresses(ma.TxId)
583583
txAddresses.AddAddress(ma.Creator)
584584
txAddresses.AddAddress(ma.SessionKey)
585+
for _, addr := range ma.Signers {
586+
txAddresses.AddAddress(addr)
587+
}
585588
return txAddresses
586589
}
587590

@@ -618,6 +621,9 @@ func (ma *MsgAuthRvSession) GetAllAddresses() *TxAddresses {
618621
txAddresses := NewTxAddresses(ma.TxId)
619622
txAddresses.AddAddress(ma.Creator)
620623
txAddresses.AddAddress(ma.SessionKey)
624+
for _, addr := range ma.Signers {
625+
txAddresses.AddAddress(addr)
626+
}
621627
return txAddresses
622628
}
623629

@@ -652,5 +658,8 @@ func (ma MsgAuthRvAllSessions) TableColumns() []string {
652658
func (ma *MsgAuthRvAllSessions) GetAllAddresses() *TxAddresses {
653659
txAddresses := NewTxAddresses(ma.TxId)
654660
txAddresses.AddAddress(ma.Creator)
661+
for _, addr := range ma.Signers {
662+
txAddresses.AddAddress(addr)
663+
}
655664
return txAddresses
656665
}

0 commit comments

Comments
 (0)