refac(indexer/schema):adjust aggregate tables similarly to db tables

Author: nman98

indexer/cli/setup.go

@@ -329,13 +329,7 @@ user does not have the required privileges.`,
 		db := timescaledb.NewTimescaleDbSetup(dbConfig)
 		dbInit := dbinit.NewDBInitializer(db.GetPool())
 
-		views := []dbinit.ContinuousAggregateDefinition{
-			s.TxCounter{},
-			s.FeeVolume{},
-			s.DailyActiveAccounts{},
-			s.ValidatorSigningCounter{},
-			s.BlockCounter{},
-		}
+		views := s.AllAggregates()
 
 		l.Info().Msg("refreshing all continuous aggregate views")
 		for _, v := range views {

pkgs/schema/assertions.go

@@ -1,5 +1,7 @@
 package schema
 
+import dbinit "github.com/Cogwheel-Validator/spectra-gnoland-indexer/indexer/db_init"
+
 // Assertion here is used as a sort of a linter for the schema.
 // If some method or parameter is missing it should fail to compile.
 
@@ -59,3 +61,13 @@ var (
 	_ DBSpecialType = Attribute{}
 	_ DBSpecialType = Event{}
 )
+
+// Continuous aggregate views are materialized views, not plain tables: they must
+// satisfy ContinuousAggregateDefinition (mt/fn/gb-driven).
+var (
+	_ dbinit.ContinuousAggregateDefinition = TxCounter{}
+	_ dbinit.ContinuousAggregateDefinition = FeeVolume{}
+	_ dbinit.ContinuousAggregateDefinition = DailyActiveAccounts{}
+	_ dbinit.ContinuousAggregateDefinition = ValidatorSigningCounter{}
+	_ dbinit.ContinuousAggregateDefinition = BlockCounter{}
+)

pkgs/schema/materialize.go

@@ -19,10 +19,6 @@ func (tc TxCounter) TableName() string {
 	return "tx_counter"
 }
 
-func (tc TxCounter) GetTableInfo() (*dbinit.TableInfo, error) {
-	return dbinit.GetTableInfo(tc, tc.TableName())
-}
-
 func (tc TxCounter) TableColumns() []string {
 	return aggColumns(tc)
 }
@@ -84,10 +80,6 @@ func (dfv FeeVolume) TableName() string {
 	return "fee_volume"
 }
 
-func (dfv FeeVolume) GetTableInfo() (*dbinit.TableInfo, error) {
-	return dbinit.GetTableInfo(dfv, dfv.TableName())
-}
-
 func (dfv FeeVolume) TableColumns() []string {
 	return aggColumns(dfv)
 }
@@ -136,10 +128,6 @@ func (dac DailyActiveAccounts) TableName() string {
 	return "daily_active_accounts"
 }
 
-func (dac DailyActiveAccounts) GetTableInfo() (*dbinit.TableInfo, error) {
-	return dbinit.GetTableInfo(dac, dac.TableName())
-}
-
 func (dac DailyActiveAccounts) TableColumns() []string {
 	return aggColumns(dac)
 }
@@ -193,10 +181,6 @@ func (vds ValidatorSigningCounter) FromTable() string {
 	return "validator_block_signing"
 }
 
-func (vds ValidatorSigningCounter) GetTableInfo() (*dbinit.TableInfo, error) {
-	return dbinit.GetTableInfo(vds, vds.TableName())
-}
-
 func (vds ValidatorSigningCounter) TableColumns() []string {
 	return aggColumns(vds)
 }
@@ -253,10 +237,6 @@ func (dbc BlockCounter) TableName() string {
 	return "block_counter"
 }
 
-func (dbc BlockCounter) GetTableInfo() (*dbinit.TableInfo, error) {
-	return dbinit.GetTableInfo(dbc, dbc.TableName())
-}
-
 func (dbc BlockCounter) TableColumns() []string {
 	return aggColumns(dbc)
 }
@@ -344,3 +324,16 @@ func aggGroupBy(v any) []string {
 	}
 	return gb
 }
+
+// AllAggregates returns one instance of every continuous aggregate view. It is
+// the single canonical list: AllAggrTableNames and the aggregate validation test
+// derive from it.
+func AllAggregates() []dbinit.ContinuousAggregateDefinition {
+	return []dbinit.ContinuousAggregateDefinition{
+		TxCounter{},
+		FeeVolume{},
+		DailyActiveAccounts{},
+		ValidatorSigningCounter{},
+		BlockCounter{},
+	}
+}

pkgs/schema/table.go

@@ -245,16 +245,10 @@ func AllTableNames() []string {
 }
 
 func AllAggrTableNames() []string {
-	tables := []DBTable{
-		TxCounter{},
-		FeeVolume{},
-		DailyActiveAccounts{},
-		ValidatorSigningCounter{},
-		BlockCounter{},
-	}
-	names := make([]string, len(tables))
-	for i, t := range tables {
-		names[i] = t.TableName()
+	aggregates := AllAggregates()
+	names := make([]string, len(aggregates))
+	for i, a := range aggregates {
+		names[i] = a.TableName()
 	}
 	return names
 }