fix(api&database): addressed the bugs for the validator queries

Author: nman98

api/huma-types/validator.go

@@ -38,7 +38,7 @@ type AllValidatorSigningsGetOutput struct {
 
 type ValidatorLastNSigningGetInput struct {
 	ValidatorAddress string             `path:"validator_address" doc:"Validator consensus address" required:"true" minLength:"40" maxLength:"40"`
-	Amount           uint64             `query:"amount" doc:"Number of last blocks to check" required:"true" example:"10" max:"100"`
+	Amount           uint64             `query:"amount" doc:"Number of last blocks to check" required:"true" example:"10" max:"100" min:"1"`
 	SortOrder        database.SortOrder `query:"sort_order" doc:"Sort order for results" enum:"asc,desc" default:"desc"`
 }
 

pkgs/database/timescaledb/queries_validator.go

@@ -72,7 +72,7 @@ func (t *TimescaleDb) GetValidatorLastNSigning(
 
 	query2 := `
    	SELECT
-        max(block_height)
+        COALESCE(max(block_height), 0)
     FROM
         validator_block_signing
     WHERE
@@ -84,8 +84,16 @@ func (t *TimescaleDb) GetValidatorLastNSigning(
 	if err != nil {
 		return nil, err
 	}
+	if maxBlockHeight == 0 {
+		return nil, fmt.Errorf("error max block height is zero for chain %s, check if the database is populated", chainName)
+	}
 
-	startHeight := maxBlockHeight - uint64(limit-1) // minus one because SQL BETWEEN is inclusive
+	var startHeight uint64
+	if limit > maxBlockHeight {
+		startHeight = 0
+	} else {
+		startHeight = maxBlockHeight - uint64(limit-1) // minus one because SQL BETWEEN is inclusive
+	}
 	order := orderBy.SQL()
 
 	query3 := fmt.Sprintf(`

pkgs/database/types.go

@@ -281,8 +281,8 @@ type AllValidatorSignings map[string]ValidatorSigning
 
 type ValInfoPerBlock struct {
 	Height   uint64 `json:"height" doc:"Block height"`
-	Proposed bool   `json:"proposer" doc:"Proposer address"`
-	Signed   bool   `json:"signed" doc:"Blocks signed"`
+	Proposed bool   `json:"proposer" doc:"Confirmation that the validator proposed the block."`
+	Signed   bool   `json:"signed" doc:"Confirmation that the validator signed the block."`
 }
 
 type ValidatorSigningsForLastNBlocks []ValInfoPerBlock