stress-chroot: fix failure return variable ret defaults

The error exit path via a break resets ret to EXIT_SUCCESS which
is incorrect. Set ret to EXIT_SUCCESS at start and allow it to
be set appropriately on exit paths.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Author: ColinIanKing

stress-chroot.c

@@ -437,7 +437,7 @@ static int stress_chroot(stress_args_t *args)
 {
 	size_t i = 0;
 	int fd;
-	int ret = EXIT_FAILURE;
+	int ret = EXIT_SUCCESS;
 	double rate;
 	chroot_shared_data_t *data;
 
@@ -462,11 +462,13 @@ static int stress_chroot(stress_args_t *args)
 	if (mkdir(temppath, S_IRWXU) < 0) {
 		pr_fail("%s: mkdir '%s' failed, errno=%d (%s)\n",
 			args->name, temppath, errno, strerror(errno));
+		ret = EXIT_FAILURE;
 		goto tidy_ret;
 	}
 	if ((fd = creat(filename, S_IRUSR | S_IWUSR)) < 0) {
 		pr_fail("%s: creat '%s' failed, errno=%d (%s)\n",
 			args->name, filename, errno, strerror(errno));
+		ret = EXIT_FAILURE;
 		goto tidy_dir;
 	}
 	(void)close(fd);
@@ -481,10 +483,8 @@ static int stress_chroot(stress_args_t *args)
 
 		pid = stress_retry_fork(args, 0);
 		if (pid < 0) {
-			if (UNLIKELY(!stress_continue(args))) {
-				ret = EXIT_SUCCESS;
+			if (UNLIKELY(!stress_continue(args)))
 				break;
-			}
 			pr_fail("%s: fork failed, errno=%d (%s)\n",
 				args->name, errno, strerror(errno));
 			ret = EXIT_FAILURE;
@@ -527,8 +527,6 @@ static int stress_chroot(stress_args_t *args)
 	rate = (data->metrics.duration > 0.0) ? data->metrics.count / data->metrics.duration : 0.0;
 	stress_metrics_set(args, "chroot calls per sec", rate, STRESS_METRIC_HARMONIC_MEAN);
 
-	ret = EXIT_SUCCESS;
-
 	if (data->cwd_fd != -1)
 		(void)close(data->cwd_fd);
 tidy_all: