CODA-Q: Migrate recent documents to common/RecentFiles

- Replace qt/RecentDocuments with common/RecentFiles
- Centralize cross-platform recent file handling
- Remove doctype filtering in File tab backstage view
- Show recent files for all document types always

Signed-off-by: codewithvk <[email protected]>
Change-Id: I0ab0bb31c95c5c5a133a57f9430a1b08e9927aa5

Author: codewithvk

browser/src/control/Control.BackstageView.ts

@@ -595,7 +595,18 @@ class BackstageView extends window.L.Class {
 
 		const fileName = doc.name || (lastSlashIndex >= 0 ? fullPath.slice(lastSlashIndex + 1) : fullPath);
 		const filePath = lastSlashIndex >= 0 ? fullPath.slice(0, lastSlashIndex + 1) : '/';
-	
+
+		if (!doc.doctype) {
+			const ext = fileName.split('.').pop()?.toLowerCase() || '';
+			if (['ods', 'ots', 'xls', 'xlsx', 'csv', 'fods'].includes(ext)) {
+				doc.doctype = 'calc';
+			} else if (['odp', 'otp', 'ppt', 'pptx', 'fodp'].includes(ext)) {
+				doc.doctype = 'impress';
+			} else {
+				doc.doctype = 'writer';  // Default
+			}
+		}
+
 		return {
 			fileName,
 			filePath,

qt/DBusService.cpp

@@ -14,17 +14,20 @@
 #include "Log.hpp"
 #include "LibreOfficeKit/LibreOfficeKit.h"
 #include "qt.hpp"
-#include "RecentDocuments.hpp"
+#include "common/RecentFiles.hpp"
 #include <Poco/URI.h>
 #include <Poco/Path.h>
 #include <QDBusConnection>
 #include <QDBusInterface>
 #include <QDBusReply>
 #include <QDBusConnectionInterface>
+#include <QFileInfo>
 
 constexpr const char* SERVICE_NAME = "com.collaboraoffice.Office";
 constexpr const char* OBJECT_PATH = "/com/collaboraoffice/Office";
 
+extern RecentFiles recentFiles;
+
 namespace coda
 {
     void openFiles(const QStringList& files)
@@ -44,7 +47,9 @@ namespace coda
             WebView* webViewInstance = new WebView(Application::getProfile());
             webViewInstance->load(fileURL);
 
-            RecentDocuments::add(file);
+            QFileInfo fileInfo(file);
+            Poco::URI uri(Poco::Path(fileInfo.absoluteFilePath().toStdString()));
+            recentFiles.add(uri.toString());
         }
     }
 

qt/Makefile.am

@@ -44,6 +44,7 @@ cmake_list= \
             ../common/Util-mobile.cpp \
             ../common/Util-unix.cpp \
             ../common/Uri.cpp \
+            ../common/RecentFiles.cpp \
             ../kit/ChildSession.cpp \
             ../kit/DeltaSimd.c \
             ../kit/Kit.cpp \
@@ -79,7 +80,7 @@ if X86
 coda_qt_CXXFLAGS += -mno-direct-extern-access
 endif
 
-coda_qt_SOURCES = coda-qt.cpp WebView.cpp DBusService.cpp RecentDocuments.cpp $(BUILT_SOURCES) $(cmake_list)
+coda_qt_SOURCES = coda-qt.cpp WebView.cpp DBusService.cpp $(BUILT_SOURCES) $(cmake_list)
 
 metainfodir = $(datadir)/metainfo
 metainfo_DATA = com.collaboraoffice.Office.metainfo.xml

qt/RecentDocuments.cpp

@@ -21,7 +21,7 @@
 #include "FileUtil.hpp"
 #include "qt.hpp"
 #include "DBusService.hpp"
-#include "RecentDocuments.hpp"
+#include "common/RecentFiles.hpp"
 
 #include <Poco/MemoryStream.h>
 #include <Poco/JSON/Parser.h>
@@ -93,6 +93,7 @@ const int SHOW_JS_MAXLEN = 300;
 int coolwsd_server_socket_fd = -1;
 static COOLWSD* coolwsd = nullptr;
 static std::thread coolwsdThread;
+RecentFiles recentFiles;
 QWebEngineProfile* Application::globalProfile = nullptr;
 
 static const char* getUserName()
@@ -606,7 +607,7 @@ bool Bridge::saveDocument(const std::string& savePath)
     if (FileUtil::copyAtomic(tempPath, savePath, false))
     {
         LOG_INF("Successfully saved file to location: " << savePath);
-        RecentDocuments::add(QString::fromStdString(savePath));
+        recentFiles.add(Poco::URI(Poco::Path(savePath)).toString());
         _pendingSave = false;
         return true;
     }
@@ -887,18 +888,8 @@ QVariant Bridge::cool(const QString& messageStr)
     }
     else if (message == "GETRECENTDOCS")
     {
-        LibreOfficeKitDocumentType docType = LOK_DOCTYPE_TEXT;
-        lok::Document* loKitDoc = DocumentData::get(_document._appDocId).loKitDocument;
-        if (loKitDoc) {
-            docType = static_cast<LibreOfficeKitDocumentType>(loKitDoc->getDocumentType());
-        }
-
-        Poco::JSON::Array::Ptr recentDocs = RecentDocuments::getForAppType(docType);
-        std::ostringstream jsonStream;
-        recentDocs->stringify(jsonStream);
-        QString result = QString::fromStdString(jsonStream.str());
-
-        LOG_TRC_NOFILE("GETRECENTDOCS: returning " << recentDocs->size() << " documents for app type");
+        QString result = QString::fromStdString(recentFiles.serialise());
+        LOG_TRC_NOFILE("GETRECENTDOCS: returning recent documents");
         return result;
     }
     else if (message.starts_with(CLIPBOARDSET))
@@ -1274,6 +1265,12 @@ int main(int argc, char** argv)
 
     Application::initialize();
 
+    // Initialize recent files
+    QString configDir = QStandardPaths::writableLocation(QStandardPaths::ConfigLocation);
+    QDir().mkpath(configDir + "/Collabora");
+    QString recentFilesPath = configDir + "/Collabora/RecentDocuments.conf";
+    recentFiles.load(recentFilesPath.toStdString(), 15);
+
     // register DBus service and object
     DBusService* dbusService = new DBusService(&app);
     DBusService::registerService(dbusService);