browser: ts: type window.app and fix all errrors

dennisfrancis · dennisfrancis · commit 56d61e5dab88 · 2026-01-06T23:26:22.000+05:30
Signed-off-by: Dennis Francis &lt;dennis.francis@collabora.com&gt;
Change-Id: Iab0d9b55006689bac3e1f532fb94320ad2da7262
diff --git a/browser/src/app/CellSelectionMarkerMiddleware.ts b/browser/src/app/CellSelectionMarkerMiddleware.ts
@@ -39,6 +39,7 @@ class CellSelectionMarkers {
 			this.start.setShowSection(true);
 			this.end.setShowSection(true);
 
+			Util.ensureValue(app.calc.cellCursorRectangle);
 			var cellRectangle = app.map._docLayer._cellSelectionArea
 				? app.map._docLayer._cellSelectionArea.clone()
 				: app.calc.cellCursorRectangle.clone();
diff --git a/browser/src/app/Log.ts b/browser/src/app/Log.ts
@@ -12,10 +12,9 @@
  * Logger contains methods for logging the activity
  */
 
-type Direction = 'INCOMING' | 'OUTGOING';
 interface LogMsg {
 	msg: string;
-	direction: Direction;
+	direction: string;
 	time: number;
 }
 
@@ -28,7 +27,7 @@ class Logger {
 		this.startTime = null;
 	}
 
-	public log(msg: string, direction: Direction): void {
+	public log(msg: string, direction: string): void {
 		const time = Date.now();
 		if (!this.startTime) this.startTime = time;
 
diff --git a/browser/src/app/SearchService.ts b/browser/src/app/SearchService.ts
@@ -73,6 +73,7 @@ class SearchService {
 
 		window.L.Map.THIS.fire('clearselection');
 
+		Util.ensureValue(app.activeDocument);
 		var searchStartPointX = app.activeDocument.activeLayout.viewedRectangle.x1;
 		var searchStartPointY = app.activeDocument.activeLayout.viewedRectangle.y1;
 		if (
diff --git a/browser/src/app/TextSelectionMiddleware.ts b/browser/src/app/TextSelectionMiddleware.ts
@@ -102,6 +102,7 @@ class TextSelections {
 		var endPos = { x: this.endRectangle.pX1, y: this.endRectangle.pY2 };
 
 		if (app.map._docLayer.isCalcRTL()) {
+			Util.ensureValue(app.activeDocument);
 			// Mirror position from right to left.
 			startPos.x =
 				app.activeDocument.activeLayout.viewedRectangle.pX2 -
diff --git a/browser/src/app/iface/Map.Interface.ts b/browser/src/app/iface/Map.Interface.ts
@@ -85,7 +85,7 @@ interface MapInterface extends Evented {
 
 	_clip: ClipboardInterface;
 
-	setPermission(permission: 'edit' | 'readonly' | 'view'): void;
+	setPermission(permission: string): void;
 	onLockFailed(reason: string): void;
 	updateModificationIndicator(newModificationTime: string): void;
 	isEditMode(): boolean;
diff --git a/browser/src/canvas/sections/AutoFillBaseSection.ts b/browser/src/canvas/sections/AutoFillBaseSection.ts
@@ -69,6 +69,7 @@ class AutoFillBaseSection extends CanvasSectionObject {
 	protected setMarkerPosition() {
 		var center: number = 0;
 		if (!(<any>window).mode.isDesktop()) {
+			Util.ensureValue(app.calc.cellCursorRectangle);
 			center = app.calc.cellCursorRectangle.pWidth * 0.5;
 		}
 
@@ -198,6 +199,7 @@ class AutoFillBaseSection extends CanvasSectionObject {
 	}
 
 	protected autoScroll(point: cool.SimplePoint) {
+		Util.ensureValue(app.activeDocument);
 		const viewedRectangle = app.activeDocument.activeLayout.viewedRectangle;
 		const viewCenter = viewedRectangle.pCenter;
 		const refX =
diff --git a/browser/src/canvas/sections/InvalidationRectangleSection.ts b/browser/src/canvas/sections/InvalidationRectangleSection.ts
@@ -49,6 +49,7 @@ class InvalidationRectangleSection extends CanvasSectionObject {
 		this.context.strokeStyle = 'red';
 
 		const anchor: number[] = this.containerObject.getDocumentAnchor();
+		Util.ensureValue(app.activeDocument);
 		const xDiff =
 			anchor[0] - app.activeDocument.activeLayout.viewedRectangle.pX1;
 		const yDiff =
diff --git a/browser/src/canvas/sections/MouseControl.ts b/browser/src/canvas/sections/MouseControl.ts
@@ -75,6 +75,7 @@ class MouseControl extends CanvasSectionObject {
 		modifier: number,
 	) {
 		let viewToDocumentPos = point.clone();
+		Util.ensureValue(app.activeDocument);
 
 		// Convert to pure canvas html element coordinate.
 		viewToDocumentPos.pX +=
@@ -121,6 +122,7 @@ class MouseControl extends CanvasSectionObject {
 
 	// Gets the mouse position on browser page in CSS pixels.
 	public getMousePagePosition() {
+		Util.ensureValue(app.activeDocument);
 		const boundingClientRectangle = this.context.canvas.getBoundingClientRect();
 		const pagePosition = this.currentPosition.clone();
 		pagePosition.pX -=
@@ -141,6 +143,7 @@ class MouseControl extends CanvasSectionObject {
 	}
 
 	private refreshPosition(point: cool.SimplePoint) {
+		Util.ensureValue(app.activeDocument);
 		let topLeftX = app.activeDocument.activeLayout.viewedRectangle.pX1;
 		let topLeftY = app.activeDocument.activeLayout.viewedRectangle.pY1;
 
@@ -161,6 +164,7 @@ class MouseControl extends CanvasSectionObject {
 		else if (app.map._docLayer._docType === 'spreadsheet') {
 			const textCursor =
 				app.file.textCursor.visible &&
+				app.calc.cellCursorRectangle &&
 				app.calc.cellCursorRectangle.pContainsPoint(
 					this.currentPosition.pToArray(),
 				);
@@ -202,6 +206,8 @@ class MouseControl extends CanvasSectionObject {
 				this.amplitude[1] * Math.exp(-elapsed / 650),
 			];
 
+			Util.ensureValue(app.activeDocument);
+
 			if (Math.abs(delta[0]) > 0.2 || Math.abs(delta[1]) > 0.2) {
 				app.activeDocument.activeLayout.scrollTo(
 					app.activeDocument.activeLayout.viewedRectangle.pX1 + delta[0],
@@ -291,6 +297,7 @@ class MouseControl extends CanvasSectionObject {
 			diff.x -= this.positionOnMouseDown.x;
 			diff.y -= this.positionOnMouseDown.y;
 
+			Util.ensureValue(app.activeDocument);
 			const viewedRectangle =
 				app.activeDocument.activeLayout.viewedRectangle.clone();
 
@@ -399,10 +406,11 @@ class MouseControl extends CanvasSectionObject {
 		else if (app.map._docLayer._docType === 'spreadsheet') {
 			const acceptInput =
 				app.calc.cellCursorVisible &&
+				app.calc.cellCursorRectangle &&
 				app.calc.cellCursorRectangle.containsPoint(
 					this.currentPosition.toArray(),
 				);
-			return acceptInput;
+			return acceptInput as boolean;
 		} else return false;
 	}
 
diff --git a/browser/src/canvas/sections/OtherViewCursorSection.ts b/browser/src/canvas/sections/OtherViewCursorSection.ts
@@ -60,6 +60,7 @@ class TextCursorSection extends HTMLObjectSection {
 		}
 
 		if (result && app.file.textCursor.visible) {
+			Util.ensureValue(app.file.textCursor.rectangle);
 			const pos = [
 				app.file.textCursor.rectangle.pX1,
 				app.file.textCursor.rectangle.pY1,
diff --git a/browser/src/canvas/sections/ShapeHandleScalingSubSection.ts b/browser/src/canvas/sections/ShapeHandleScalingSubSection.ts
@@ -347,6 +347,7 @@ class ShapeHandleScalingSubSection extends CanvasSectionObject {
 
 	// While dragging a handle, we want to simulate handles to their final positions.
 	moveHandlesOnDrag(point: cool.SimplePoint, e: MouseEvent) {
+		Util.ensureValue(app.activeDocument);
 		const shapeRecProps = this.calculateNewShapeRectangleProperties([
 			point.pX + this.myTopLeft[0] + app.activeDocument.activeLayout.viewedRectangle.pX1 - this.containerObject.getDocumentAnchor()[0],
 			point.pY + this.myTopLeft[1] + app.activeDocument.activeLayout.viewedRectangle.pY1 - this.containerObject.getDocumentAnchor()[1]
diff --git a/browser/src/canvas/sections/SplitterLinesSection.ts b/browser/src/canvas/sections/SplitterLinesSection.ts
@@ -160,6 +160,7 @@ class SplitterLinesSection extends CanvasSectionObject {
 
 				if (splitPos.x) {
 					let width, style;
+					Util.ensureValue(app.activeDocument);
 					if (app.activeDocument.activeLayout.viewedRectangle.pX1 === 0) {
 						width = this.sectionProperties.thickness;
 						style = this.sectionProperties.fillColor;
@@ -180,6 +181,7 @@ class SplitterLinesSection extends CanvasSectionObject {
 
 				if (splitPos.y) {
 					let width, style;
+					Util.ensureValue(app.activeDocument);
 					if (app.activeDocument.activeLayout.viewedRectangle.pY1 === 0) {
 						width = this.sectionProperties.thickness;
 						style = this.sectionProperties.fillColor;
diff --git a/browser/src/canvas/sections/TableResizeMarkerSection.ts b/browser/src/canvas/sections/TableResizeMarkerSection.ts
@@ -41,6 +41,7 @@ class TableResizeMarkerSection extends HTMLObjectSection {
 	}
 
 	private calculateLeftMostAndRightMostAvailableX() {
+		Util.ensureValue(app.activeDocument);
 		const previous =
 			this.sectionProperties.index === 0
 				? null
@@ -75,6 +76,7 @@ class TableResizeMarkerSection extends HTMLObjectSection {
 	}
 
 	private calculateTopMostAndBottomMostAvailableY() {
+		Util.ensureValue(app.activeDocument);
 		const previous =
 			this.sectionProperties.index === 0
 				? null
@@ -136,6 +138,7 @@ class TableResizeMarkerSection extends HTMLObjectSection {
 
 	private getParametersForRow() {
 		let index: number, type: string;
+		Util.ensureValue(app.activeDocument);
 		if (
 			this.sectionProperties.index ===
 			app.activeDocument.tableMiddleware.tableResizeRowMarkers.length - 1
@@ -152,6 +155,7 @@ class TableResizeMarkerSection extends HTMLObjectSection {
 
 	private getParametersForColumn() {
 		let index: number, type: string;
+		Util.ensureValue(app.activeDocument);
 		if (this.sectionProperties.index === 0) {
 			type = 'column-left';
 			index = 0;
@@ -277,6 +281,7 @@ class TableResizeMarkerSection extends HTMLObjectSection {
 			this.containerObject.isDraggingSomething() &&
 			this.containerObject.targetSection === this.name
 		) {
+			Util.ensureValue(app.activeDocument);
 			if (this.sectionProperties.markerType === 'column') {
 				const bottomy =
 					app.activeDocument.tableMiddleware.getTableBottomY() -
diff --git a/browser/src/canvas/sections/TableSelectMarkerSection.ts b/browser/src/canvas/sections/TableSelectMarkerSection.ts
@@ -73,6 +73,7 @@ class TableSelectMarkerSection extends HTMLObjectSection {
 
 	public onClick(point: cool.SimplePoint, e: MouseEvent): void {
 		this.stopPropagating(e);
+		Util.ensureValue(app.activeDocument);
 		if (this.sectionProperties.markerType === 'column') {
 			const x1 = Math.round(
 				(this.position[0] + this.size[0] * 0.5) * app.pixelsToTwips,
diff --git a/browser/src/control/Control.ContextToolbar.ts b/browser/src/control/Control.ContextToolbar.ts
@@ -100,6 +100,7 @@ class ContextToolbar extends JSDialogComponent {
 			if (!TextSelections || !(statRect = TextSelections.getStartRectangle()))
 				return;
 			const pos = { x: statRect.cX1, y: statRect.cY1 };
+			Util.ensureValue(app.activeDocument);
 			pos.x -=
 				(app.activeDocument.activeLayout.viewedRectangle.pX1 -
 					app.sectionContainer.getDocumentAnchor()[0]) /
diff --git a/browser/src/core/geometry.ts b/browser/src/core/geometry.ts
@@ -112,8 +112,14 @@ export class SimplePoint {
 	}
 
 	// View pixel.
-	public get vX(): number { return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewX(this) : this.pX; }
-	public get vY(): number { return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewY(this) : this.pY; }
+	public get vX(): number {
+		Util.ensureValue(app.activeDocument);
+		return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewX(this) : this.pX;
+	}
+	public get vY(): number {
+		Util.ensureValue(app.activeDocument);
+		return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewY(this) : this.pY;
+	}
 }
 
 /**
@@ -255,14 +261,38 @@ export class SimpleRectangle {
 	}
 
 	// View pixel. 1..4 represents the 4 corners of the rectangle: TopLeft, TopRight, BottomLeft, BottomRight respectively.
-	public get v1X(): number { return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewX(new cool.SimplePoint(this.x1, this.y1)) : this.pX1; }
-	public get v1Y(): number { return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewY(new cool.SimplePoint(this.x1, this.y1)) : this.pY1; }
-	public get v2X(): number { return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewX(new cool.SimplePoint(this.x2, this.y1)) : this.pX2; }
-	public get v2Y(): number { return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewY(new cool.SimplePoint(this.x2, this.y1)) : this.pY1; }
-	public get v3X(): number { return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewX(new cool.SimplePoint(this.x1, this.y2)) : this.pX1; }
-	public get v3Y(): number { return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewY(new cool.SimplePoint(this.x1, this.y2)) : this.pY2; }
-	public get v4X(): number { return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewX(new cool.SimplePoint(this.x2, this.y2)) : this.pX2; }
-	public get v4Y(): number { return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewY(new cool.SimplePoint(this.x2, this.y2)) : this.pY2; }
+	public get v1X(): number {
+		Util.ensureValue(app.activeDocument);
+		return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewX(new cool.SimplePoint(this.x1, this.y1)) : this.pX1;
+	}
+	public get v1Y(): number {
+		Util.ensureValue(app.activeDocument);
+		return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewY(new cool.SimplePoint(this.x1, this.y1)) : this.pY1;
+	}
+	public get v2X(): number {
+		Util.ensureValue(app.activeDocument);
+		return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewX(new cool.SimplePoint(this.x2, this.y1)) : this.pX2;
+	}
+	public get v2Y(): number {
+		Util.ensureValue(app.activeDocument);
+		return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewY(new cool.SimplePoint(this.x2, this.y1)) : this.pY1;
+	}
+	public get v3X(): number {
+		Util.ensureValue(app.activeDocument);
+		return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewX(new cool.SimplePoint(this.x1, this.y2)) : this.pX1;
+	}
+	public get v3Y(): number {
+		Util.ensureValue(app.activeDocument);
+		return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewY(new cool.SimplePoint(this.x1, this.y2)) : this.pY2;
+	}
+	public get v4X(): number {
+		Util.ensureValue(app.activeDocument);
+		return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewX(new cool.SimplePoint(this.x2, this.y2)) : this.pX2;
+	}
+	public get v4Y(): number {
+		Util.ensureValue(app.activeDocument);
+		return app.activeDocument.activeLayout ? app.activeDocument.activeLayout.documentToViewY(new cool.SimplePoint(this.x2, this.y2)) : this.pY2;
+	}
 }
 
 /*
diff --git a/browser/src/docstate.ts b/browser/src/docstate.ts
@@ -15,7 +15,7 @@
 		* app.sectionContainer.addSection(new app.definitions.CellFillMarkerSection());
 		* var cellFillSection = new app.definitions.CellFillMarkerSection();
 */
-window.app = {
+(window.app as any) = {
 	/*
 	 * These are from <vcl/keycodes.h>. Correspond to the published
 	 * com::sun::star::awt::KeyModifier constants, left-shifted by 12.
diff --git a/browser/src/global.d.ts b/browser/src/global.d.ts

Original file line number	Diff line number	Diff line change
`@@ -69,6 +69,7 @@ class AutoFillBaseSection extends CanvasSectionObject {`
`69`	`69`	`protected setMarkerPosition() {`
`70`	`70`	`var center: number = 0;`
`71`	`71`	`if (!(<any>window).mode.isDesktop()) {`
	`72`	`+ Util.ensureValue(app.calc.cellCursorRectangle);`
`72`	`73`	`center = app.calc.cellCursorRectangle.pWidth * 0.5;`
`73`	`74`	`}`
`74`	`75`
`@@ -198,6 +199,7 @@ class AutoFillBaseSection extends CanvasSectionObject {`
`198`	`199`	`}`
`199`	`200`
`200`	`201`	`protected autoScroll(point: cool.SimplePoint) {`
	`202`	`+ Util.ensureValue(app.activeDocument);`
`201`	`203`	`const viewedRectangle = app.activeDocument.activeLayout.viewedRectangle;`
`202`	`204`	`const viewCenter = viewedRectangle.pCenter;`
`203`	`205`	`const refX =`
Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,7 @@ class TextCursorSection extends HTMLObjectSection {`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`if (result && app.file.textCursor.visible) {`
	`63`	`+ Util.ensureValue(app.file.textCursor.rectangle);`
`63`	`64`	`const pos = [`
`64`	`65`	`app.file.textCursor.rectangle.pX1,`
`65`	`66`	`app.file.textCursor.rectangle.pY1,`