Skip to content

Commit 7282483

Browse files
committed
browser: a11y: fix logo link in document
The href attribute is not set. It should be customized, but ensure the element is focusable. Change-Id: Ia63e77047e8e46147886fb94e4f9eb561a463579 Signed-off-by: Henry Castro <[email protected]>
1 parent f916a1b commit 7282483

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

browser/src/control/Control.Menubar.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2397,7 +2397,6 @@ class Menubar extends window.L.Control {
23972397
$(aItem).data('type', 'action');
23982398
aItem.setAttribute('role', 'img');
23992399
aItem.setAttribute('aria-label', _('file type icon'));
2400-
aItem.href = '#';
24012400
aItem.target = '_blank';
24022401

24032402
if (window.logoURL) {

browser/src/control/Control.Notebookbar.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,8 @@ window.L.Control.Notebookbar = window.L.Control.extend({
106106

107107
$(docLogo).data('id', 'document-logo');
108108
$(docLogo).data('type', 'action');
109-
docLogo.href = '#';
110109
docLogo.target = '_blank';
110+
docLogo.tabIndex = 0;
111111

112112
if (iconTooltip) {
113113
docLogo.setAttribute('data-cooltip', iconTooltip);

0 commit comments

Comments
 (0)