Skip to content

Commit 7e357c6

Browse files
committed
Remove the hidden <dialog> About template from cool.html.m4.
The About dialog is now fully created and filled in JavaScript using: - createAboutDialogContent() to build the structure - window.app.serverInfo to provide version and server details - populateAboutDialog() to insert all content and branding - This removes the need for duplicated HTML in the template file and makes the dialog easier to maintain. - A minimal empty <div id=\"about-dialog\" tabIndex=\"0\"></div> is kept in the HTML to preserve Notebookbar About tab detection Signed-off-by: Banobe Pascal <[email protected]> Change-Id: Id0bea4b6892b62fe4a9396c8d941f79ee5e39b97
1 parent 9eeb6b4 commit 7e357c6

File tree

1 file changed

+1
-31
lines changed

1 file changed

+1
-31
lines changed

browser/html/cool.html.m4

Lines changed: 1 addition & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -213,37 +213,7 @@ m4_ifelse(MOBILEAPP,[true],
213213
</div>
214214

215215
<!-- Remove if you don't want the About dialog -->
216-
<dialog>
217-
<div id="about-dialog" tabIndex="0">
218-
<div id="about-dialog-header">
219-
<fig id="integrator-logo"></fig>
220-
<h1 id="product-name">Collabora Online</h1>
221-
</div>
222-
<hr/>
223-
<div id="about-dialog-container">
224-
<div id="about-dialog-logos">
225-
<fig id="product-logo"></fig>
226-
<fig id="lokit-logo"></fig>
227-
</div>
228-
<div id="about-dialog-info-container">
229-
<div id="about-dialog-info">
230-
<div id="coolwsd-version-label"></div>
231-
<div class="about-dialog-info-div"><div id="coolwsd-version" dir="ltr"></div></div>
232-
<div class="spacer"></div>
233-
<div id="lokit-version-label"></div>
234-
<div class="about-dialog-info-div"><div id="lokit-version" dir="ltr"></div></div>
235-
m4_ifelse(MOBILEAPP,[],[<div id="served-by"><span id="served-by-label"></span>&nbsp;<span id="os-info"></span>&nbsp;<wbr><span id="coolwsd-id"></span></div>],[<p></p>])
236-
<div id="slow-proxy"></div>
237-
m4_ifelse(DEBUG,[true],[<div id="js-dialog">JSDialogs: <a href="#">View widgets</a></div>])
238-
<div id="routeToken"></div>
239-
<div id="timeZone"></div>
240-
m4_ifelse(MOBILEAPP,[],[<div id="wopi-host-id">%WOPI_HOST_ID%</div>],[<p></p>])
241-
<p class="about-dialog-info-div"><span dir="ltr">Copyright © _YEAR_, VENDOR.</span></p>
242-
</div>
243-
</div>
244-
</div>
245-
</div>
246-
</dialog>
216+
<div id="about-dialog" tabIndex="0"></div>
247217

248218
m4_ifelse(MOBILEAPP, [true],
249219
[

0 commit comments

Comments
 (0)