Respond to Copilot review comments

Note: while the changes were done by hand, the review comments were written by AI (GitHub Copilot)

Author: vegerot

minigamepad.h

@@ -2704,8 +2704,6 @@ typedef struct mg_field {
 } mg_field;
 
 
-#define BUTTON_FIELDS_START 1
-#define AXIS_FIELDS_START 18
 
 MG_API mg_bool parseMapping(mg_mapping* mapping, const char* string);
 mg_bool parseMapping(mg_mapping* mapping, const char* string) {
@@ -2714,7 +2712,7 @@ mg_bool parseMapping(mg_mapping* mapping, const char* string) {
     mg_field fields[] = {
         { "platform", 8,     0, NULL },
 
-        [BUTTON_FIELDS_START] = { "a", 1,             MG_BUTTON_SOUTH , NULL},
+        { "a", 1,             MG_BUTTON_SOUTH , NULL},
         { "b", 1,           MG_BUTTON_EAST , NULL},
         { "x", 1,            MG_BUTTON_WEST , NULL},
         { "y", 1,            MG_BUTTON_NORTH , NULL},
@@ -2732,21 +2730,24 @@ mg_bool parseMapping(mg_mapping* mapping, const char* string) {
         { "lefttrigger", 11,   MG_BUTTON_LEFT_TRIGGER , NULL},
         { "righttrigger", 12,  MG_BUTTON_RIGHT_TRIGGER , NULL },
 
-        [AXIS_FIELDS_START] = { "lefttrigger", 11,   MG_AXIS_LEFT_TRIGGER, NULL},
+        { "lefttrigger", 11,   MG_AXIS_LEFT_TRIGGER, NULL},
         { "righttrigger", 12,  MG_AXIS_RIGHT_TRIGGER, NULL },
         { "leftx",  5,       MG_AXIS_LEFT_X, NULL },
         { "lefty",  5,       MG_AXIS_LEFT_Y, NULL } ,
         { "rightx", 6,       MG_AXIS_RIGHT_X, NULL},
         { "righty", 6,        MG_AXIS_RIGHT_Y, NULL }
     };
 
+    static const mg_size_t button_fields_start = 1;
+    static const mg_size_t axis_fields_count = 6;
     len = (sizeof(fields) / sizeof(mg_field));
+    mg_size_t axis_start = len - axis_fields_count;
 
-    for (i = BUTTON_FIELDS_START; i < AXIS_FIELDS_START; i++) {
+    for (i = button_fields_start; i < axis_start; i++) {
         fields[i].element = &mapping->buttons[fields[i].val];
     }
 
-    for (i = AXIS_FIELDS_START; i < len; i++) {
+    for (i = axis_start; i < len; i++) {
         fields[i].element = &mapping->axes[fields[i].val];
     }