Merge pull request #15 from ColyTeam/feature/better-error-handling

Better Error Handling

Author: klegul

main/src/main/java/com/shirkanesi/magmaplayer/ytdlp/YTDLPAudioTrack.java

@@ -112,7 +112,6 @@ private void pullAudioStreamAsync(String streamUrl, File tempFile) {
 
                     while (pullProcess.getInputStream().available() < MIN_AVAILABLE_BYTES) {
                         // Yes, this is busy waiting. The author does not know a better solution.
-                        // TODO: find better solution
                         Thread.sleep(100);
                     }
 
@@ -149,6 +148,8 @@ private String findStreamUrl(String commandTemplate, String url) throws IOExcept
             process.destroy();
         }
 
+        handleErrorInProcess(process);
+
         try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(process.getInputStream()))) {
             return bufferedReader.readLine();
         }
@@ -273,6 +274,8 @@ public AudioTrackInformation getInformation() throws AudioPlayerException {
                 process.destroy();
             }
 
+            handleErrorInProcess(process);
+
             String json;
             try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(process.getInputStream()))) {
                 // yt-dlp will not put any line-breaks into the response ==> one line is enough
@@ -285,4 +288,21 @@ public AudioTrackInformation getInformation() throws AudioPlayerException {
             throw new AudioPlayerException("Could not load track information", e);
         }
     }
+
+    private void handleErrorInProcess(Process process) {
+        if (process.exitValue() != 0) {
+            StringBuilder content = new StringBuilder();
+            try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(process.getErrorStream()))) {
+                String line;
+                while ((line = bufferedReader.readLine()) != null) {
+                    content.append(line).append("\n");
+                }
+
+            } catch (IOException e) {
+                throw new AudioTrackPullException("Error while reading from source-stream", e);
+            }
+            throw new AudioTrackPullException("Error while reading from source-stream: " + content);
+        }
+    }
+
 }