N°9327 Do not enter readonly or maintenance mode when doing data audit

Author: Timmy38

setup/compiler.class.inc.php

@@ -278,7 +278,7 @@ public static function SkipRebuildHKeys()
 	 * @return void
 	 * @throws Exception
 	 */
-	public function Compile($sTargetDir, $oP = null, $bUseSymbolicLinks = null, $bSkipTempDir = false)
+	public function Compile($sTargetDir, $oP = null, $bUseSymbolicLinks = null, $bSkipTempDir = false, $bEnterMaintenanceMode = true)
 	{
 		if (is_null($bUseSymbolicLinks)) {
 			$bUseSymbolicLinks = false;
@@ -297,8 +297,7 @@ public function Compile($sTargetDir, $oP = null, $bUseSymbolicLinks = null, $bSk
 		} else {
 			$oConfig = null;
 		}
-		if (($this->sEnvironment == 'production') && !$bIsAlreadyInMaintenanceMode) {
-
+		if (($this->sEnvironment == 'production') && !$bIsAlreadyInMaintenanceMode && $bEnterMaintenanceMode) {
 			SetupUtils::EnterMaintenanceMode($oConfig);
 		}
 		if ($bUseSymbolicLinks || $bSkipTempDir) {

setup/sequencers/ApplicationInstallSequencer.php

@@ -429,12 +429,12 @@ protected function DoBackup($sBackupFileFormat, $sSourceConfigFile, $sMySQLBinDi
 	 *
 	 * @since 3.1.0 N°2013 added the aParamValues param
 	 */
-	protected function DoCompile($aRemovedExtensionCodes, $aSelectedModules, $sSourceDir, $sExtensionDir, $bUseSymbolicLinks = null)
+	protected function DoCompile($aRemovedExtensionCodes, $aSelectedModules, $sSourceDir, $sExtensionDir, $bUseSymbolicLinks = null, $bEnterMaintenanceMode = true)
 	{
 		/**
-	 * @since 3.2.0 move the ContextTag init at the very beginning of the method
-	 * @noinspection PhpUnusedLocalVariableInspection
-	 */
+		 * @since 3.2.0 move the ContextTag init at the very beginning of the method
+		 * @noinspection PhpUnusedLocalVariableInspection
+		 */
 		$oContextTag = new ContextTag(ContextTag::TAG_SETUP);
 
 		SetupLog::Info("Compiling data model.");
@@ -471,7 +471,7 @@ protected function DoCompile($aRemovedExtensionCodes, $aSelectedModules, $sSourc
 
 		$bIsAlreadyInMaintenanceMode = SetupUtils::IsInMaintenanceMode();
 
-		if (($sEnvironment == 'production') && !$bIsAlreadyInMaintenanceMode) {
+		if (($sEnvironment == 'production') && !$bIsAlreadyInMaintenanceMode && $bEnterMaintenanceMode) {
 			$sConfigFilePath = utils::GetConfigFilePath($sEnvironment);
 			if (is_file($sConfigFilePath)) {
 				$oConfig = new Config($sConfigFilePath);
@@ -531,7 +531,7 @@ protected function DoCompile($aRemovedExtensionCodes, $aSelectedModules, $sSourc
 			}
 
 			$oMFCompiler = new MFCompiler($oFactory, $sEnvironment);
-			$oMFCompiler->Compile($sTargetPath, null, $bUseSymbolicLinks);
+			$oMFCompiler->Compile($sTargetPath, null, $bUseSymbolicLinks, false, $bEnterMaintenanceMode);
 			//$aCompilerLog = $oMFCompiler->GetLog();
 			//SetupLog::Info(implode("\n", $aCompilerLog));
 			SetupLog::Info("Data model successfully compiled to '$sTargetPath'.");

setup/sequencers/DataAuditSequencer.php

@@ -57,7 +57,6 @@ public function ExecuteStep($sStep = '', $sInstallComment = null)
 		try {
 			$fStart = microtime(true);
 			SetupLog::Info("##### STEP {$sStep} start");
-			$this->EnterReadOnlyMode();
 			switch ($sStep) {
 				case '':
 					$this->DoLogParameters('data-audit-', 'Data Audit');
@@ -83,6 +82,7 @@ public function ExecuteStep($sStep = '', $sInstallComment = null)
 						$aSelectedModules,
 						$sSourceDir,
 						$sExtensionDir,
+						false,
 						false
 					);
 
@@ -145,7 +145,6 @@ public function ExecuteStep($sStep = '', $sInstallComment = null)
 			];
 
 			$this->ReportException($e);
-			$this->ExitReadOnlyMode();
 		} finally {
 			$fDuration = round(microtime(true) - $fStart, 2);
 			SetupLog::Info("##### STEP {$sStep} duration: {$fDuration}s");