Fix PHP CS

Author: v-dumas

core/userrights.class.inc.php

@@ -427,8 +427,7 @@ public function DoCheckToWrite()
 						$this->m_aCheckIssues[] = Dict::S('Class:User/Error:AdminProfileCannotBeRemovedBySelf');
 					}
 				}
-			}
-			elseif ($this->IsPrivilegedUser()) {
+			} elseif ($this->IsPrivilegedUser()) {
 				// Prevent Privileged User to be saved with profiles denying the access to the backoffice
 				$oSet->Rewind();
 				while ($oUserProfile = $oSet->Fetch()) {

tests/php-unit-tests/src/BaseTestCase/ItopDataTestCase.php

@@ -661,17 +661,15 @@ protected function RemoveProfileFromUser($oUser, $iProfileId)
 	{
 		/** @var \ormLinkSet $oSet */
 		$oSet = $oUser->Get('profile_list');
-		foreach ($oSet as $oUserProfile)
-		{
-			if ($oUserProfile->Get('profileid') == $iProfileId)
-			{
+		foreach ($oSet as $oUserProfile) {
+			if ($oUserProfile->Get('profileid') == $iProfileId) {
 				$oSet->RemoveItem($oUserProfile->GetKey());
 				break;
 			}
 		}
-		$oUser = $this->updateObject(User::class, $oUser->GetKey(), array(
+		$oUser = $this->updateObject(User::class, $oUser->GetKey(), [
 			'profile_list' => $oSet,
-		));
+		]);
 		return $oUser;
 	}
 

tests/php-unit-tests/unitary-tests/core/UserRightsTest.php

@@ -87,12 +87,12 @@ protected function GivenUserWithProfiles(string $sLogin, array $aProfileIds): DB
 		foreach ($aProfileIds as $iProfileId) {
 			$oProfiles->AddItem(MetaModel::NewObject('URP_UserProfile', ['profileid' => $iProfileId, 'reason' => 'UNIT Tests']));
 		}
-		$oUser = MetaModel::NewObject('UserLocal',  array(
+		$oUser = MetaModel::NewObject('UserLocal', [
 			'login' => $sLogin,
 			'password' => 'Password1!',
 			'expiration' => UserLocal::EXPIRE_NEVER,
 			'profile_list' => $oProfiles,
-		));
+		]);
 		return $oUser;
 	}
 
@@ -336,9 +336,9 @@ public function testUserCannotElevateTheirOwnRights(int $iCurrentProfileId, int
 	public function UserCannotElevateTheirOwnRightsProvider(): array
 	{
 		return [
-			'Configuration manager to SuperUser' => ['current'=> 3, 'added' => 117],
-			'Configuration manager to Administrator'         => ['current'=> 3, 'added' => 1],
-			'SuperUser to Administrator'         => ['current'=> 117, 'added' => 1],
+			'Configuration manager to SuperUser' => ['current' => 3, 'added' => 117],
+			'Configuration manager to Administrator'         => ['current' => 3, 'added' => 1],
+			'SuperUser to Administrator'         => ['current' => 117, 'added' => 1],
 		];
 	}
 
@@ -417,7 +417,6 @@ public function testUserCannotLoseUserEditionRights(int $iProfileId)
 		$this->RemoveProfileFromUser($oUser, $iProfileId);
 	}
 
-
 	public function UserCannotLoseUserEditionRightsProvider(): array
 	{
 		return [