Description
CEA-708-E DefineWindow
(DF0 - DF7) declares:
window style ID
: when non-zero, specifies 1 of 7 present window attribute styles...pen style ID
: when non-zero, specifies 1 of 7 present pen attribute styles...
Tables 26 and 27 define these presets, starting at 1.
Caption Inspector interprets the window style IDs starting at 0:
caption-inspector/src/sink/dtvcc_output.c
Lines 116 to 118 in 476326f
And pen style IDs starting at 0:
caption-inspector/src/sink/dtvcc_output.c
Lines 73 to 75 in 476326f
As a result, Caption Inspector interprets every window and pen style off-by-one, eg: Pen Style 5 (ProportSanSerif
, NTSC Style Prop w/o Serif) is reported as MonoSanSerif-TransBG
.
The fix would be to remove the "Unknown"
value at the end of each of the predefPenStyle
and predefWinStyle
arrays, and replace it with an "Undefined"
value at the start of each array.
Relatedly, WINDOW_STYLE_*
defines are also incorrect, and start at 0 instead of 1:
caption-inspector/include/dtvcc_decode.h
Lines 376 to 382 in 476326f