Skip to content

Commit a6c2fee

Browse files
remove Mend PR checks since we migrated to Snyk, add security context to helm chart deployment (#103)
1 parent 4942a23 commit a6c2fee

File tree

4 files changed

+14
-10
lines changed

4 files changed

+14
-10
lines changed

.github/workflows/pr-prechecks.yml

-9
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,6 @@ jobs:
2525
- name: Run go test
2626
run: make test
2727

28-
- name: Run Whitesource/Mend scan
29-
run: |
30-
curl -LJO https://github.com/whitesource/unified-agent-distribution/releases/latest/download/wss-unified-agent.jar
31-
export WS_CHECHKPOLICIES=true
32-
export WS_FORCECHECKALLDEPENDENCIES=true
33-
export WS_FORCEUPDATE=true
34-
export WS_UPDATEINVENTORY=true
35-
java -jar wss-unified-agent.jar -apiKey ${{ secrets.MEND_API_KEY }} -product ${{ secrets.MEND_PRODUCT_NAME }} -project WS-fishymetrics
36-
3728
build:
3829
runs-on: ubuntu-latest
3930
steps:

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ log is based on the [Keep a CHANGELOG](http://keepachangelog.com/) project.
66

77
## Unreleased
88

9+
## Updated
10+
11+
- increase security context for kubernetes helm chart deployment [#102](https://github.com/Comcast/fishymetrics/issues/102)
12+
913
## [0.12.1]
1014

1115
## Fixed

helm/fishymetrics/Chart.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ maintainers:
77
88
name: Ibrahim Khalilullah Khan
99
name: fishymetrics
10-
version: 0.10.4
10+
version: 0.10.5

helm/fishymetrics/templates/deployment.yaml

+9
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,15 @@ spec:
4848
ports:
4949
- containerPort: {{ .Values.exporter.port }}
5050
name: exporter
51+
securityContext:
52+
allowPrivilegeEscalation: false
53+
readOnlyRootFilesystem: true
54+
runAsNonRoot: true
55+
runAsUser: 1000
56+
capabilities:
57+
drop:
58+
- ALL
59+
add: ["NET_BIND_SERVICE"]
5160
args:
5261
{{- if .Values.credentials }}
5362
- --credentials.profiles={{ toJson .Values.credentials }}

0 commit comments

Comments
 (0)