add a nil reference check during retries (#98)

* add a nil reference check during retries

* update CHANGELOG

Author: derrick-dacosta

CHANGELOG.md

@@ -6,6 +6,12 @@ log is based on the [Keep a CHANGELOG](http://keepachangelog.com/) project.
 
 ## Unreleased
 
+## Fixed
+
+- nil pointer dereference during a scrape [#97](https://github.com/Comcast/fishymetrics/issues/97)
+
+## [0.12.0]
+
 ## Added
 
 - Add ability to reference different vault paths for credential retrieval [#25](https://github.com/Comcast/fishymetrics/issues/25)

common/util.go

@@ -56,6 +56,9 @@ func Fetch(uri, host, profile string, client *retryablehttp.Client) func() ([]by
 				for retryCount < 3 && resp.StatusCode == http.StatusNotFound {
 					time.Sleep(client.RetryWaitMin)
 					resp, err = DoRequest(client, req)
+					if err != nil {
+						return nil, err
+					}
 					retryCount = retryCount + 1
 				}
 				if err != nil {

exporter/moonshot/exporter.go

@@ -212,6 +212,9 @@ func fetch(uri, device, metricType, host, profile string, client *retryablehttp.
 				for retryCount < 3 && resp.StatusCode == http.StatusNotFound {
 					time.Sleep(client.RetryWaitMin)
 					resp, err = common.DoRequest(client, req)
+					if err != nil {
+						return nil, device, metricType, err
+					}
 					retryCount = retryCount + 1
 				}
 				if err != nil {